cannot quickly package if spaces in parent folder name

Bug #636277 reported by Tony Byrne
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
cdbs
Fix Released
Unknown
cdbs (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

How to trigger bug
create folder with a space in its name
open terminal in the folder
quickly create then quickly package

Terminal dump ---------------
tony@tony-laptop:~/projects/a a$ quickly create ubuntu-application jotty
Creating project directory jotty
Creating bzr repository and commiting
Launching your newly created project!le 0/1
Congrats, your new project is setup! cd /home/tony/projects/a a/jotty/ to start hacking.
tony@tony-laptop:~/projects/a a$ cd jotty
tony@tony-laptop:~/projects/a a/jotty$ quickly package
......Ubuntu packaging created in debian/
....................................................................................................................An error has occurred during package building
ERROR: package command failed
Aborting
tony@tony-laptop:~/projects/a a/jotty$ cd ..
tony@tony-laptop:~/projects/a a$ ls
jotty jotty_0.1.dsc jotty_0.1.tar.gz

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

it's definitively not related to Quickly, but more or distutils.

However, I can't get the issue right now, postponing.

cd . && python setup.py install --root=/home/didrocks/Projets/sandbox/a a/too/debian/too/ \
  --install-purelib=/usr/lib/python2.6/site-packages/ --prefix=/usr --no-compile -O0

The issue is --root=/home/didrocks/Projets/sandbox/a a/too/debian/too/
which should be
--root='/home/didrocks/Projets/sandbox/a a/too/debian/too'
but this is is launched before auto.py from python-distutils-extra is used, so I would a distutils bug?

Revision history for this message
Michael Terry (mterry) wrote :

This is a bug with /usr/share/cdbs/1/class/python-distutils.mk shipped in the cdbs package. I'm moving it over and working on a patch.

affects: quickly → cdbs
Changed in cdbs:
assignee: nobody → Michael Terry (mterry)
status: New → In Progress
Revision history for this message
Michael Terry (mterry) wrote :

I'm just attaching a simple patch rather than a debdiff or bzr branch, since I didn't want to write a changelog that will get out of date if this doesn't make it for maverick, as seems likely.

This patch simply wraps the directories in quotes to handle any spaces. Works for me.

Simple test is:

mkdir "/tmp/a a"
cd "/tmp/a a"
quickly create ubuntu-application test
cd test
quickly package

Changed in cdbs:
assignee: Michael Terry (mterry) → nobody
status: In Progress → Confirmed
Changed in cdbs (Ubuntu):
status: New → Confirmed
Michael Terry (mterry)
Changed in cdbs:
importance: Undecided → Unknown
status: Confirmed → Unknown
Revision history for this message
Artur Rona (ari-tczew) wrote :

Subscribing ubuntu-release, as need an ACK for upload.

Revision history for this message
Scott Kitterman (kitterman) wrote :

unsubscribing ubuntu-release. This should be dealt with as a normal upload in Natty.

Changed in cdbs:
status: Unknown → New
Revision history for this message
Martin Pitt (pitti) wrote :

Applied to bzr, thanks Mike!

Changed in cdbs (Ubuntu):
status: Confirmed → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (6.0 KiB)

This bug was fixed in the package cdbs - 0.4.89ubuntu1

---------------
cdbs (0.4.89ubuntu1) natty; urgency=low

  * Merge from debian unstable, remaining changes:
    - 1/class/autotools-files.mk.in: Add -i option when calling libtoolize to
      install missing files. (Debian #525849)
    - 1/class/gnome.mk.in:
      + Include langpack.mk.
      + Check if $DEB_BUILDDIR actually exists before cd'ing to it.
    - Add 1/class/kde4.mk.in: Generic KDE4 build rules. Install it in
      Makefile.am.
    - 1/class/kde.mk.in:
      + Call dh_icons and bump autogenerated debhelper build dependency
        appropriately.
      + Add --without-arts to standard configure flags, since it is
        deprecated.
      + build POT file, and add X-Ubuntu-Gettext-Domain to .desktop files.
     - Add 1/rules/clean-la.mk.in: Remove dependency_libs lines from .la files.
       Install it in Makefile.am.
    - 1/rules/debhelper.mk.in:
      + Do not install upstream changelogs by default. They are huge and thus
        waste a lot of archive and CD space, quite uninteresting for ordinary
        users, and easy to get by downloading the source package or visiting the
        upstream page pointed out in copyright.
      + Symlink /usr/share/doc/ files to identical versions in any depending
        package which is built by the source package (except copyright, to
        adhere to Debian Policy). This can be disabled by setting
        $CDBS_NO_DOC_SYMLINKING.
      + Symlink identical Gnome help files (like untranslated images). This
        can be disabled by setting $CDBS_NO_GNOME_HELP_SYMLINKING. Add fdupes
        dependency for this.
    - Add 1/rules/langpack.mk.in: Generic langpack related tasks: Build POT
      files, add X-Ubuntu-Gettext-Domain to .desktop/.server/.directory
      files, and strip translations from gconf schemas. Install file in
      Makefile.am. Add intltool dependency for this.
    - Add strip-schema.pl: Script to remove translations from gconf schemas.
      Install it in Makefile.am.
    - 1/rules/simple-patchsys.mk.in: Revert the change for Debian bug #387103
      that causes patches to be unapplied before cleaning the build directory;
      the original issue was addressed more thoroughly in 0.4.49 with a fix
      for Debian bug #424080, and unpatch-before-clean breaks some relevant
      use cases that involve patching of build systems. (Debian #494254)
    - 1/rules/utils.mk.in: add some text before listing missing file to make
      it easier to see from the build log (LP #509249)
    - scripts/cdbs-edit-patch: Add fallback if DEB_TAR_SRCDIR contains
      variables. (LP #137827)
    - test/testsuite_functions: Set NO_PKG_MANGLE so that tests do not fail
      with pkgstriptranslations installed.
    - Add test/i18n: New test package for testing i18n. For now, ship a couple
      of .desktop files in different variants (simple, with translations, with
      initial empty line, with multiple sections).
    - Add test/langpack-1.mk: Verify that langpack.mk's translation stripping
      and domain addition works in all four cases above.
  * 1/class/python-distutils.mk.in: Fix building for directories with spaces
    in the na...

Read more...

Changed in cdbs (Ubuntu):
status: Fix Committed → Fix Released
Changed in cdbs:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.