Ubuntu
xchat package

privmsgs from "nicks not to be highlighted" are highlighted

Bug #669046 reported by Fabien Tassin
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
xchat (Debian)
Fix Released
Unknown
xchat (Ubuntu)
Fix Released
Low
Fabien Tassin

Bug Description

Binary package hint: xchat

In prefs / Chatting / Alerts:
- check "Alerts" / "Make a beep sound on" / "Private Message"
- add a nick in "Highlighted Messages" / "Nick names not to highlight"

now ask that nick to send you a private message.

xchat beeps. It should not.

In my case, I was annoyed by messages from "-bip" and "NickServ".

Already reported with a patch in Debian weeks ago (and ignored so far).
I'm landing it in natty then.

Related branches

lp:ubuntu/natty/xchat
Revision history for this message
Fabien Tassin (fta) wrote :

Here is my patch

Changed in xchat (Ubuntu):
assignee: nobody → Fabien Tassin (fta)
importance: Undecided → Low
status: New → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package xchat - 2.8.8-3ubuntu2

---------------
xchat (2.8.8-3ubuntu2) natty; urgency=low

  * debian/patches/71_fix_nick_not_to_highlight.patch
    + Fix "nicks not to hightlight" for privmsg (LP: #669046)
 -- Fabien Tassin <email address hidden> Sun, 31 Oct 2010 11:01:37 +0100

Changed in xchat (Ubuntu):
status: In Progress → Fix Released
Bug Watch Updater (bug-watch-updater)
Changed in xchat (Debian):
status: Unknown → New
Bug Watch Updater (bug-watch-updater)
Changed in xchat (Debian):
status: New → Won't Fix
Revision history for this message
Fabien Tassin (fta) wrote :

I don't understand the won't fix from debian. a nick listed as not to highlight should not highlight even with privmsgs.
So please, don't backout this fix from Ubuntu, unless there's something better achieving the same goal.

Revision history for this message
Evan Clinton (nave-notnilc) wrote :

Hi, I'd like to note that your patch here causes XChat to drop any messages, in a channel or in PM, from anyone on the 'do not highlight' list. I expect this was not quite your goal, though it certainly does prevent a beep from possibly occurring due to these people.

Revision history for this message
Rainer Müller (raimue) wrote :

This patch is totally wrong as xchat now ignores all users from this instead of just not producing a highlight. Please revert this patch or fix it correctly.

For reference: LP #735656

Revision history for this message
Alexander A. (the2ndhare) wrote :

The patch in question does more harm than good. Please consider removing it or repairing so that it achieves the original purpose without breaking anything else. Thank you.

Bug Watch Updater (bug-watch-updater)
Changed in xchat (Debian):
status: Won't Fix → Fix Released
Bug Watch Updater (bug-watch-updater)
Changed in xchat (Debian):
status: Fix Released → Won't Fix
Bug Watch Updater (bug-watch-updater)
Changed in xchat (Debian):
status: Won't Fix → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.