Ubuntu
network-manager package

network-manager has overaggressive dependency on update-notifier-common

Bug #669925 reported by Evan Broder
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
network-manager (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

Binary package hint: network-manager

network-manager uses /usr/share/update-notifier/notify-reboot-required to trigger a reboot in its postinst.

update-notifier-common was made a dependency of network-manager to fix bug #255844.

However, every other package I've ever seen which uses notify-reboot-required has no dependency on update-notifier-common, and instead just only runs notify-reboot-required if it's available, and does nothing if it's not.

I would appreciate seeing this dependency removed and replaced with logic to test for notify-reboot-required's existence, as I use network-manager but not update-notifier, and installing network-manager unnecessarily pulls in update-notifier's dependency chain.

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Thanks for the patch!

I'm assigning this to myself for the sponsoring or merging this fix in network-manager. We use lp:~network-manager/network-manager/ubuntu.head as the "official" branch for NM packaging. Would it be possible for you to apply your fix in clone of that branch and issue a new merge request? Thanks!

Changed in network-manager (Ubuntu):
assignee: nobody → Mathieu Trudel (mathieu-tl)
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Just merged your branch in the NM head branch, so this will get uploaded soon.

Changed in network-manager (Ubuntu):
status: Triaged → Fix Committed
assignee: Mathieu Trudel (mathieu-tl) → nobody
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package network-manager - 0.8.3~git.20101118t223039.d60a988-0ubuntu1

---------------
network-manager (0.8.3~git.20101118t223039.d60a988-0ubuntu1) natty; urgency=low

  * upstream snapshot 2010-11-18 22:30:39 (GMT)
    + d60a988518cb0851488bc21732271a971877cdcd

  [ Evan Broder ]
  * Check for notify-reboot-required, instead of depending on it being
    available. (LP: #669925)

  [ Mathieu Trudel-Lapierre ]
  * explicitly always get HEAD rather than the branch's name in get-orig-source
    - update debian/rules
  * drop do-not-include-netif.patch; the header conflict was fixed in a kernel
    update
    - remove debian/patches/do-not-include-netif.patch
    - update debian/patches/series
  * Short-circuit the /etc/hosts update mechanisms to avoid adding useless
    localhost(6?).localdomain(6?) on loopback addresses. (LP: #677496)
    - add debian/patches/never-localhostlocaldomain.patch
    - update debian/patches/series
 -- Mathieu Trudel-Lapierre <email address hidden> Mon, 22 Nov 2010 09:35:21 -0500

Changed in network-manager (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.