Newer Version Available

Fixed this bug.
Waiting for reviews or any error in packaging, if any please tell I'll fix them.
Thank you.

Thanks for working on this.

I see you dropped debian/patches/01-sigc_namespace.patch, saying that it has been merged upstream. This doesn't appear to be the case though. In your new source package it seems you added debian/patches/debian-changes-1.6.0-0ubuntu1, which has the same contents as the patch you dropped.

This patch was autogenerated when you built the source package. I think what has happened is you checked the source code with the original patch applied (perhaps without realising it) and then deleted the patch, thinking that it had been included upstream.

Would you mind fixing this please?

Thanks

I fixed all the errors in comment.
Looking forward for more reviews.
Thank you

Thanks, looking good!

One small comment though:

* Dropped patch 03-configure.patch, doesn't apply

In general, that's not a good reason to drop a patch. However, in this case though I don't see a need for this patch anyway, so I think it's ok to drop. But, I will just clarify that in the changelog before I upload it.

Hmmm, this actually fails to build here. Firstly:

checking for intltool >= 0.35.0... ./configure: line 6945: intltool-update: command not found
 found
configure: error: Your intltool is too old. You need intltool 0.35.0 or later.

This is because the build dependencies need updating (you need to add intltool, libglademm-2.4-dev and change libxml++1.0-dev to libxml++2.6-dev).

This can be seen in this part of the diff between 1.4.0 and 1.6.0:

diff -Nru bibshelf-1.4.0/configure.ac bibshelf-1.6.0/configure.ac
--- bibshelf-1.4.0/configure.ac 1970-01-01 01:00:00.000000000 +0100
+++ bibshelf-1.6.0/configure.ac 2008-12-20 21:32:04.000000000 +0000
@@ -0,0 +1,46 @@
+dnl Process this file with autoconf to produce a configure script.
+dnl Created by Anjuta application wizard.
+
+AC_INIT(bibshelf, 1.6.0, http://debain.org/software/bibshelf)
+
+PACKAGE_PIXMAPS_DIR=$(datadir)/pixmaps
+AC_SUBST(PACKAGE_PIXMAPS_DIR)
+
+AM_INIT_AUTOMAKE(AC_PACKAGE_NAME, AC_PACKAGE_VERSION)
+AM_CONFIG_HEADER(config.h)
+AM_MAINTAINER_MODE
+
+AC_ISC_POSIX
+AC_PROG_CXX
+AM_PROG_CC_STDC
+AC_HEADER_STDC
+
+
+
+
+dnl ***************************************************************************
+dnl Internatinalization
+dnl ***************************************************************************
+GETTEXT_PACKAGE=bibshelf
+AC_SUBST(GETTEXT_PACKAGE)
+AC_DEFINE_UNQUOTED(GETTEXT_PACKAGE,"$GETTEXT_PACKAGE", [GETTEXT package name])
+AM_GLIB_GNU_GETTEXT
+IT_PROG_INTLTOOL([0.35.0])
+
+
+
+
+
+PKG_CHECK_MODULES(BIBSHELF, [gtkmm-2.4 >= 2.8 libglademm-2.4 >= 2.6 libxml++-2.6 libcurl])
+AC_SUBST(BIBSHELF_CFLAGS)
+AC_SUBST(BIBSHELF_LIBS)
+
+
+
+
+AC_OUTPUT([
+Makefile
+src/Makefile
+po/Makefile.in
+pixmaps/Makefile
+])
diff -Nru bibshelf-1.4.0/configure.in bibshelf-1.6.0/configure.in
--- bibshelf-1.4.0/configure.in 2005-02-15 14:10:29.000000000 +0000
+++ bibshelf-1.6.0/configure.in 1970-01-01 01:00:00.000000000 +0100
@@ -1,107 +0,0 @@
-dnl Process this file with autoconf to produce a configure script.
-dnl Created by Anjuta - will be overwritten
-dnl If you don't want it to overwrite it,
-dnl Please disable it in the Anjuta project configuration
-
-AC_INIT(configure.in)
-AM_INIT_AUTOMAKE(bibshelf, 1.4.0)
-AM_CONFIG_HEADER(config.h)
-
-AC_ISC_POSIX
-CXXFLAGS=""
-AC_SUBST(CXXFLAGS)
-AC_PROG_CXX
-AM_PROG_CC_STDC
-AC_HEADER_STDC
-AM_PROG_LIBTOOL
-PKG_CHECK_MODULES(GTK, gtk+-2.0 gdk-2.0,,exit)
-AC_SUBST(GTK_LIBS)
-AC_SUBST(GTK_CFLAGS)
-dnl Checks for programs.
-dnl Checks for libraries.
-dnl Checks for header files.
-dnl Checks for typedefs, structures, and compiler characteristics.
-dnl Checks for library functions.
-dnl Checks for Additional stuffs.
-GETTEXT_PACKAGE=bibshelf
-AC_SUBST(GETTEXT_PACKAGE)
-AC_DEFINE_UNQUOTED(GETTEXT_PACKAGE, "$GETTEXT_PACKAGE", [Package name for gettext])
-
-
-dnl Languages which your application supports
-ALL_LINGUAS="de es it ga vi"
-AM_GNU_GETTEXT
-AM_GNU_GETTEXT_VERSION(0.10.40)
-
-dnl Set PACKAGE_LOCALE_DIR in config.h.
-if test "x${prefix}" = "xNONE"; then
- AC_DEFINE_UNQUOTED(PACKAGE_LOCALE_DIR, "${ac_default_prefix}/${DATADIRNAME}/locale")
-else
- AC_DEFINE_UNQUOTED(PACKAGE_LOCALE_DIR, "${prefix}/${DATADIRNAME}/locale")
-fi
-
-
-dnl Set PACKAGE SOURCE DIR...

This bug was fixed in the package bibshelf - 1.6.0-0ubuntu1

---------------
bibshelf (1.6.0-0ubuntu1) natty; urgency=low

  [ Tarun Kumar Mall <email address hidden> ]
  * New upstream release (LP: #713023)
  * Dropped patch 02-string_h.patch, applied upstream
  * Dropped patch 03-configure.patch, doesn't seem to be needed (there
    are no patches touching the build system)
  * Bumped Standards-Version, no other changes needed.

  [ Chris Coulson <email address hidden> ]
  * Updated build dependencies (libxml++1.0-dev => libxml++2.6-dev, add
    intltool and libglademm-2.4-dev)
  * The upstream tarball has an invalid POTFILES.in, breaking "make
    check". Add patch to fix this
    - add debian/patches/02-potfiles_fix.patch
 -- Tarun Kumar Mall <email address hidden> Sat, 05 Feb 2011 09:12:49 +0530

Note, the POTFILES.in issues is this: http://code.google.com/p/bibshelf/issues/detail?id=2