armagetronad version 0.2.8.3.1-1 failed to build on i386

Unless there are aspects of the upcoming new C++ standard (or the current standard) that elude me, this is a problem with the compiler. The various tPathX have no explicit constructor at all, hence the compiler should generate an automatic default constructor and use that for the initialization of the various st_X objects.

Obvious workarounds: add an empty default constructor.

I also had the same problem compiling on Fedora 15
$ uname -r
2.6.38.6-27.fc15.x86_64

$ g++ --version
g++ (GCC) 4.6.0 20110509 (Red Hat 4.6.0-7)

g++ -DHAVE_CONFIG_H -I. -I.. -I. -I.. -I/usr/include/libxml2 -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT -I/usr/include/libpng12 -I./tools -O2 -Wno-long-long -MT libtools_a-tDirectories.o -MD -MP -MF .deps/libtools_a-tDirectories.Tpo -c -o libtools_a-tDirectories.o `test -f 'tools/tDirectories.cpp' || echo './'`tools/tDirectories.cpp
tools/tDirectories.cpp:502:26: error: uninitialized const ‘st_Config’ [-fpermissive]
tools/tDirectories.cpp:474:7: note: ‘const class tPathConfig’ has no user-provided default constructor
tools/tDirectories.cpp:523:24: error: uninitialized const ‘st_Data’ [-fpermissive]
tools/tDirectories.cpp:505:7: note: ‘const class tPathData’ has no user-provided default constructor
tools/tDirectories.cpp:549:23: error: uninitialized const ‘st_Var’ [-fpermissive]
tools/tDirectories.cpp:526:7: note: ‘const class tPathVar’ has no user-provided default constructor
tools/tDirectories.cpp:571:30: error: uninitialized const ‘st_Screenshot’ [-fpermissive]
tools/tDirectories.cpp:552:7: note: ‘const class tPathScreenshot’ has no user-provided default constructor
tools/tDirectories.cpp:633:28: error: uninitialized const ‘st_Resource’ [-fpermissive]
tools/tDirectories.h:59:7: note: ‘const class tPathResource’ has no user-provided default constructor
make[3]: *** [libtools_a-tDirectories.o] Error 1

Adding default constructors and it now compiles, I also moved the classes out of the .cpp file and into the .h file - I'm sure there is a reason why they are there?

I attached this a patch.

From <http://gcc.gnu.org/gcc-4.6/changes.html>:
"""
G++ no longer allows objects of const-qualified type to be default initialized unless the type has a user-declared default constructor. Code that fails to compile can be fixed by providing an initializer e.g.
    struct A { A(); };
    struct B : A { };
    const B b = B();

Use -fpermissive to allow the old, non-conforming behaviour.
"""

Also, see this gcc bug report: <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44499>

This issue was fixed in lp:armagetronad/0.2.8, but has not yet made it in to an official release.

This was the patch: <http://bazaar.launchpad.net/~armagetronad-dev/armagetronad/0.2.8-armagetronad-work/revision/1275>

A fix will be released in 0.2.8.3.2, which is currently going through beta testing. 0.2.8.3.2 will also include a few security patches.

http://forums3.armagetronad.net/viewtopic.php?f=50&t=21778

I'll keep an eye on the forum for updates; in the meantime, I'm pushing this fix (r1275) to Oneiric and submitting to BTS.

This bug was fixed in the package armagetronad - 0.2.8.3.1-1ubuntu1

---------------
armagetronad (0.2.8.3.1-1ubuntu1) oneiric; urgency=low

  * Add 01_g++-4.6: Apply upstream r1275 to resolve FTBFS.
    (Closes: #625079) (LP: #765939)
 -- Daniel T Chen <email address hidden> Mon, 29 Aug 2011 20:36:45 -0400