lightdm-gtk-greeter segfaults in get_user_iter when adding a new user
Bug #822470 reported by
Jason Conti
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Light Display Manager |
Fix Released
|
High
|
Robert Ancell | ||
| lightdm (Ubuntu) |
Fix Released
|
High
|
Unassigned | ||
Bug Description
Steps to reproduce with lightdm-gtk-greeter 0.9.2:
1) Switch to another vt or login through ssh
2) sudo adduser someusername
3) lightdm-gtk-greeter will crash
The segfault occurs when user_changed_cb is triggered. When a new user is added, the user is appended to the end of the list, so when user_changed_cb calls get_user_iter, it will search through every row before finally finding the user at the end. However, the name for the "Other..." user is NULL, so when strcmp is called, the greeter crashes.
Related branches
lp:~jconti/lightdm/check_null_user
- Robert Ancell: Disapprove
-
Diff: 21 lines (+3/-1)1 file modifiedgreeters/gtk/lightdm-gtk-greeter.c (+3/-1)
Revision history for this message
| Sebastien Bacher (seb128) wrote | #1 |
| Changed in lightdm: | |
| assignee: | nobody → Robert Ancell (robert-ancell) |
| status: | New → Confirmed |
| Changed in lightdm (Ubuntu): | |
| status: | New → Triaged |
| importance: | Undecided → High |
| Changed in lightdm: | |
| importance: | Undecided → High |
| status: | Confirmed → Fix Committed |
| Changed in lightdm (Ubuntu): | |
| status: | Triaged → Fix Committed |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #2 |
| Changed in lightdm (Ubuntu): | |
| status: | Fix Committed → Fix Released |
| Changed in lightdm: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
There is a patch on http://
Do you think you could maybe do a merge request from it? It would show on the review queue this way, you can click on "Propose for merging" on the https:/