byobu-launcher-install: should refer to byobu-launch with the full path

Bug #854764 reported by Daniel Hahler
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
byobu (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

I am creating a oh-my-zsh plugin for zsh (https://github.com/blueyed/oh-my-zsh/tree/master/plugins/byobu).

Therefore byobu is installed in a custom location and the path and BYOBU_PREFIX are setup when the plugin loads (which is after ~/.zprofile gets sourced).

I think the fix would be as simple as using $BYOBU_PREFIX to byobu-launch in install_launcher() (byobu-launcher-install).

Revision history for this message
Dustin Kirkland  (kirkland) wrote :

Howdy!

Thanks for the bug report.

I'm not sure about this...

Is "byobu-launch" in your path? ie:
 $ which byobu-launch

If so, this should work fine (at least it does in bash):
 . byobu-launch

Can you confirm $(which byobu-launch)?

Changed in byobu (Ubuntu):
importance: Undecided → Low
status: New → Incomplete
Revision history for this message
Daniel Hahler (blueyed) wrote :

As said in the original report, the $PATH gets adjusted to include byobu after ~/.zprofile gets loaded.
Therefore byobu-launch is not in the path yet.

Apart from that, I would like to install the currently used version explicitly, so that byobu in my $HOME gets used, and not a system-wide installed one (if any).

Changed in byobu (Ubuntu):
status: Incomplete → New
Revision history for this message
Dustin Kirkland  (kirkland) wrote :

Okay, then we need to rearrange how byobu-launcher-install works with zsh.

We absolutely need the $PATH to include the path to the byobu-* helper scripts.

Where would be the right place to put the . byobu-launch, in zsh world?

Changed in byobu (Ubuntu):
status: New → Incomplete
Revision history for this message
Dustin Kirkland  (kirkland) wrote :

Any ideas, Daniel?

Changed in byobu (Ubuntu):
status: Incomplete → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (4.6 KiB)

This bug was fixed in the package byobu - 4.47-0ubuntu1

---------------
byobu (4.47-0ubuntu1) precise; urgency=low

  * etc/profile.d/Z97-byobu.sh:
    - remove unnecessary 'true'
  * usr/share/byobu/ec2/Makefile.am, usr/share/byobu/ec2/rates.ap-
    northeast-1, usr/share/byobu/ec2/rates.ap-southeast-1,
    usr/share/byobu/ec2/rates.eu-west-1, usr/share/byobu/ec2/rates.us-
    east-1, usr/share/byobu/ec2/rates.us-west-1,
    usr/share/byobu/ec2/rates.us-west-2: LP: #888196
    - added new us-west-2 (Oregon) pricing region
  * close LP: #888106, fixed in last release
  * usr/share/byobu/profiles/tmux, usr/share/doc/byobu/help.tmux.txt,
    usr/share/doc/byobu/Makefile.am:
    - add a tmux keybinding help screen, bind to Shift-F1
  * usr/share/byobu/profiles/tmux, usr/share/doc/byobu/help.tmux.txt:
    - add a keybinding Ctrl-Shift-F2 to create a new session
  * usr/share/byobu/profiles/tmux:
    - rearrange to match help text; would be good to keep these
      coordinated
  * usr/share/byobu/profiles/tmux, usr/share/doc/byobu/help.tmux.txt:
    - Alt-F11 breaks split into new window
    - Shift-F11 puts window into a horizontal split in previous window
    - Ctrl-F11 puts window into a vertical split in previous window
  * usr/share/doc/byobu/help.tmux.txt:
    - fix typo
  * usr/share/byobu/keybindings/f-keys.tmux,
    usr/share/byobu/keybindings/f-keys.tmux.disable,
    usr/share/byobu/keybindings/Makefile.am,
    usr/share/byobu/profiles/tmux, usr/share/doc/byobu/help.tmux.txt:
    - LP: #888247
    - Add Shift-F12 to toggle keybindings on/off
    - Split tmux keybindings to separate file to source
  * usr/bin/byobu-status-detail, usr/lib/byobu/.constants,
    usr/share/byobu/keybindings/f-keys.tmux:
    - set a BYOBU_PAGER environment variable
    - use BYOBU_PAGER in places we need a pager
  * === added directory usr/lib/byobu/include, experimental/byobu-
    classroom, usr/bin/byobu, usr/bin/byobu-ctrl-a, usr/bin/byobu-
    disable, usr/bin/byobu-enable, usr/bin/byobu-export, usr/bin/byobu-
    janitor, usr/bin/byobu-launch, usr/bin/byobu-launcher,
    usr/bin/byobu-launcher-install, usr/bin/byobu-launcher-uninstall,
    usr/bin/byobu-quiet, usr/bin/byobu-reconnect-sockets, usr/bin/byobu-
    select-backend, usr/bin/byobu-select-profile, usr/bin/byobu-shell,
    usr/bin/byobu-silent, usr/bin/byobu-status, usr/bin/byobu-status-
    detail, usr/bin/byobu-ugraph, usr/bin/byobu-ulevel,
    usr/lib/byobu/.common => usr/lib/byobu/include/common (properties
    changed: -x to +x), usr/lib/byobu/.constants =>
    usr/lib/byobu/include/constants, usr/lib/byobu/.dirs =>
    usr/lib/byobu/include/dirs, usr/lib/byobu/Makefile.am,
    usr/lib/byobu/notify_osd, usr/lib/byobu/.notify_osd =>
    usr/lib/byobu/include/notify_osd, usr/lib/byobu/.shutil =>
    usr/lib/byobu/include/shutil, configure.ac, Makefile.am,
    usr/lib/byobu/include/Makefile.am:
    - LP: #833768
    - move dotfiles out of usr/lib/byobu and into usr/lib/byobu/include
    - this was triggering some chrootkit warnings
  * usr/share/doc/byobu/help.tmux.txt:
    - reorder some documentation
  * usr/bin/byobu-launcher-install:
    - close LP: #854764, which was recently fixed
  * us...

Read more...

Changed in byobu (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.