Ubuntu
ubuntu-dev-tools package

[syncpackage] --no-lp picks up to many changelog entries in certain situations

Bug #878868 reported by James Page
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntu-dev-tools (Ubuntu)
Invalid
Low
Unassigned

Bug Description

I noticed this when using the --no-lp option to deal with a number of fakesync's from Debian for new packages which landed in Ubuntu first (so have a -0ubuntuX version number).

When the changelog is generated its generated since 'cur_ver.full_version' - which relates to the Debian version associated with the current Ubuntu version. In the case below

ubuntu_ver.full_version = 1.1-0ubuntu1
cur_ver.full_version = 1.1-0

As a result the changelog generated contains the full change history. This is OK if the Ubuntu changelog entries have been discarded during adoption in Debian (as we want the full changelog) but if they are intact then they are included.

See https://lists.ubuntu.com/archives/precise-changes/2011-October/000411.html for example.

ProblemType: Bug
DistroRelease: Ubuntu 11.10
Package: ubuntu-dev-tools 0.132ubuntu0.1
ProcVersionSignature: Ubuntu 3.0.0-12.20-generic 3.0.4
Uname: Linux 3.0.0-12-generic x86_64
NonfreeKernelModules: fglrx
ApportVersion: 1.23-0ubuntu3
Architecture: amd64
Date: Thu Oct 20 14:46:11 2011
InstallationMedia: Ubuntu 11.04 "Natty Narwhal" - Release amd64 (20110426)
PackageArchitecture: all
SourcePackage: ubuntu-dev-tools
UpgradeStatus: Upgraded to oneiric on 2011-09-09 (40 days ago)

Revision history for this message
James Page (james-page) wrote :
Revision history for this message
Stefano Rivera (stefanor) wrote :

I'm not entirely sure why we bother with get_related_debian_version(). I'm tempted to apply the attached patch.

Revision history for this message
Stefano Rivera (stefanor) wrote :

Of course, the reason this happened here is that the "1.1-0ubuntu1" entry appears in Debian's changelog.

Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "syncpackage-878868.patch" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-sponsors please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

tags: added: patch
Revision history for this message
Stefano Rivera (stefanor) wrote : Re: syncpackage --no-lp picks up to many changelog entries in certain situations

Err FWIW, this patch is bad in it's current form. I think it'd break syncing NEW packages.

Revision history for this message
Benjamin Drung (bdrung) wrote :

We need to find the last common version in the changelogs. Example:

Debian releases 1.0-1
Ubuntu syncs it
Debian releases 1.5-1
Ubuntu updates the package to 2.0-0ubuntu1
Debian releases 2.1-1

When we do the sync, we need the changelog for 1.5-1 and 2.1-1.

Benjamin Drung (bdrung)
Changed in ubuntu-dev-tools (Ubuntu):
importance: Undecided → Low
Revision history for this message
Stefano Rivera (stefanor) wrote :

Currently blocked on bug 833384

Benjamin Drung (bdrung)
summary: - syncpackage --no-lp picks up to many changelog entries in certain
+ [syncpackage] --no-lp picks up to many changelog entries in certain
situations
Revision history for this message
Dan Streetman (ddstreet) wrote :

please reopen if this problem still exists

Changed in ubuntu-dev-tools (Ubuntu):
status: New → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.