Please merge rosegarden 11.11.11-1 (universe) from Debian testing

status confirmed
subscribe ubuntu-sponsors
done

rosegarden (1:11.11.11-1ubuntu1) precise; urgency=low

  * Merge from Debian testing (LP: #905015). Remaining changes:
    - Fixed configure for multi-arch (LP: #832832).

 -- Leo Iannacone <email address hidden> Thu, 15 Dec 2011 23:34:07 +0100

I realise that this was upoaded in oneiric with the same patch, but that patch doesn't seem correct:

QTLIB_SEARCH="$QTDIR/lib $QTDIR/lib64 $QTDIR/lib32 $QTDIR/bin /usr/lib /usr/lib/i386-linux-gnu /usr/lib/x86_64-linux-gnu /usr/lib64"

This causes build failures on armel, armhf and powerpc because it hardcodes the triplets for i386 and amd64 only. A better approach would maybe be to use the output of 'dpkg-architecture -qDEB_HOST_MULTIARCH' to find the QT libraries.

I had a really quick look at it and it seems that something like

dh_auto_configure -- --enable-debug --with-qtlibdir=/usr/lib/$(shell dpkg-architecture -qDEB_HOST_MULTIARCH)

in debian/rules should be enough to get it built. The correct fix however is to use proper pkg-config macros in configure.ac and run autoreconf to regen the scripts.

What do you think about this?

The attachment "debdiff_11.11.11-1_11.11.11-1ubuntu1.patch" of this bug report has been identified as being a patch in the form of a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-sponsors team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

While your patch DTRT, I found out that the patch that should enable multiarch building got accidently reverted in upstream's svn prior to the release. Could you include the patch from http://rosegarden.svn.sourceforge.net/viewvc/rosegarden/trunk/rosegarden/acinclude.m4?r1=11271&r2=12426&view=patch
and resubmit? Please include DEP3 patch headers! Thanks and sorry for the additional workload!

Done... :)

And thanks for help...

This is the buildlog on 64bit machine.

Thanks, corrected typo in changelog entry and uploaded.

This bug was fixed in the package rosegarden - 1:11.11.11-1ubuntu1

---------------
rosegarden (1:11.11.11-1ubuntu1) precise; urgency=low

  * Merge from Debian testing (LP: #905015).
  * Drop changes:
    - Fixed configure for multi-arch (LP: #832832), FTBFS with armel.
  * Imported fix-multiarch-build.patch from upstream to corretly fix
    FTBFS with multiarch, thanks to Andreas Moog.
 -- Leo Iannacone <email address hidden> Fri, 16 Dec 2011 16:22:19 +0100

This is a better way and do not FTFBS in i386, as reported in my ppa:

https://launchpadlibrarian.net/87601874/buildlog_ubuntu-precise-i386.rosegarden_1%3A11.11.11-1ubuntu1_BUILDING.txt.gz

Fix in rosegarden 1:11.11.11-1ubuntu2