dvdstyler crashes referencing deleted subtitle tracks

Bug #910926 reported by Aisano
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
dvdstyler (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

When a video title is removed from a dvdstyler project, all its subtitle tracks are removed, too. They may, however, still be referenced in a subtitle menu. This causes the following problem:

Opening the "properties" dialogue of a menu button referencing such a deleted subtitle track may cause dvdstyler to crash in line 125 of MenuObjectPropDlg.cpp, where the index into the "labels" array is out of bounds.

A simple patch would consist in replacing the label of the missing track by the "off" item. I made such a patch and will upload it. It might, however, be a cleaner solution to remove all references to subtitle tracks when a title is removed.

I am using Ubuntu 11.11; uname -rv says "3.0.0-15-generic-pae #24-Ubuntu SMP Mon Dec 12 17:21:42 UTC 2011." Synaptic says my dvdstyler is 1.8.3-ubuntu2.1.

Tags: patch

Related branches

Revision history for this message
Aisano (info-ais-sanmarino) wrote :
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "symptomatic patch for "index out of bounds" problem due to removed subtitle tracks" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

tags: added: patch
Revision history for this message
Aisano (info-ais-sanmarino) wrote :

Alex Thüring informed me that the problem already has been fixed. (Ubuntu uses version 1.8.3 but the head version is 2.1.)

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package dvdstyler - 2.1-0ubuntu1

---------------
dvdstyler (2.1-0ubuntu1) precise; urgency=low

  * New upstream release
    - This fixes a crash when deleting referenced subtitles (LP: #910926)
  * debian/watch: updated to get only stable versions
  * debian/control:
    - bump standards-version to 3.9.2. No changes are required.
    - Add b-d on libavfilter-dev as libavfilter is required now
  * binutils-gold.patch: dropped as it has been adopted upstream
  * libav-0.7.patch: dropped as this is not applicable anymore
  * genisoimage.patch: refreshed
  * fix-libav0.8.patch: fix FTBFS with libav 0.8
  * debian/rules: call first dh_auto_clean to be able to build it twice in a row
 -- Fabrice Coutadeur <email address hidden> Sun, 12 Feb 2012 18:57:08 +0100

Changed in dvdstyler (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.