Ubuntu
indicator-messages package

indicator-messages-service memory leak

Bug #923629 reported by Jean-Baptiste Lallement
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Messaging Menu
Fix Released
High
Daniel d'Andrada
Messaging Menu 0.5.90
indicator-messages (Ubuntu)
Fix Released
High
Unassigned
libindicator (Ubuntu)
Fix Released
High
Unassigned

Bug Description

monitoring indicator-messages-services shows a memory leak of 2.3MB/hour, no matter the system is active or idle.
Chart attached.

ProblemType: Bug
DistroRelease: Ubuntu 12.04
Package: indicator-messages 0.5.0-1ubuntu1
ProcVersionSignature: Ubuntu 3.2.0-11.19-generic 3.2.1
Uname: Linux 3.2.0-11-generic x86_64
ApportVersion: 1.91-0ubuntu1
Architecture: amd64
Date: Mon Jan 30 09:12:03 2012
EcryptfsInUse: Yes
InstallationMedia: Ubuntu 11.10 "Oneiric Ocelot" - Release amd64 (20111012)
ProcEnviron:
 PATH=(custom, user)
 LANG=en_US.utf8
 SHELL=/bin/bash
SourcePackage: indicator-messages
UpgradeStatus: No upgrade log present (probably fresh install)

Related branches

lp:~dandrader/libindicator/plug-leak-pkeyfile
Ted Gould (community): Approve
Diff: 11 lines (+1/-0)
1 file modified
libindicator/indicator-desktop-shortcuts.c (+1/-0)
lp:~dandrader/indicator-messages/plug-leaks
Lars Karlitski (community): Approve
Diff: 49 lines (+8/-1)
2 files modified
src/launcher-menu-item.c (+5/-1)
src/messages-service.c (+3/-0)
lp:~dandrader/libindicate/plug-leak-gpropcb
Ted Gould (community): Approve
Diff: 20 lines (+2/-1)
1 file modified
libindicate/listener.c (+2/-1)
Superseded for merging into lp:libindicate/0.6
Indicator Applet Developers: Pending requested
Diff: 20 lines (+2/-1)
1 file modified
libindicate/listener.c (+2/-1)
lp:ubuntu/precise/libindicator
Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :
Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :
tags: added: qa-manual-testing
Revision history for this message
Ted Gould (ted) wrote :

Interesting chart. What's even more interesting to me is that it's a step function... so that means something is happening at those points... we might have a way to track this!

So could you get a bustle log started at the same times so that perhaps we could correlate the steps with what's happening on dbus? That'd be done like this:

  $ bustle-dbus-monitor > indicator-messages.bustle

Then attach the file with the memory graph. Thanks!

Changed in indicator-messages:
status: New → Incomplete
importance: Undecided → High
Daniel d'Andrada (dandrader)
Changed in indicator-messages:
assignee: nobody → Daniel d'Andrada (dandrader)
Revision history for this message
Daniel d'Andrada (dandrader) wrote :

I did see an increase in memory consumption overtime, although way less dramatic than in that graph. That was in 12.04 though. Maybe improvements have been made on that front since that time?

Ted Gould (ted)
Changed in indicator-messages:
milestone: none → 0.5.90
Revision history for this message
Daniel d'Andrada (dandrader) wrote :

Had a test run with the trunk versions of libindicate, libindicator and indicator-messages with my patches (listed in the "Related branches" section) applied on top of them.

In 10 hours its writeable/private memory (as reported by pmap) grew only 128 KB (from 26272KB to 26400KB) and that growth happened at once (one single step) and not like the steady growth showed on that graph.

Thus I think that the related software in 12.04 was already much less leaky than in 11.10 and that with my small patches applied to them I didn't notice any constant memory consumption growth anymore.

Sebastien Bacher (seb128)
Changed in indicator-messages (Ubuntu):
status: New → Fix Committed
importance: Undecided → High
status: Fix Committed → Incomplete
status: Incomplete → Fix Committed
Changed in libindicator (Ubuntu):
importance: Undecided → High
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libindicator - 0.4.91-0ubuntu1

---------------
libindicator (0.4.91-0ubuntu1) precise; urgency=low

  * New upstream release.
    * Visibility fixes for indicators using that functionality
    * Ensure that parent_object is more aggressively set
    * Fix memory leak on groups of items in desktop files (lp: #923629)
  * Dropping debian/patches
  * Upstream Merge
    * Explicitly add in gmodule as a required library
  * debian/control, debian/rules:
    * Adding in autoreconf support
    * Adding a check rule and requiring new build deps
 -- Ted Gould <email address hidden> Tue, 14 Feb 2012 14:29:51 -0600

Changed in libindicator (Ubuntu):
status: Fix Committed → Fix Released
Charles Kerr (charlesk)
Changed in indicator-messages (Ubuntu):
status: Fix Committed → Fix Released
Changed in indicator-messages:
status: Incomplete → Fix Released
Revision history for this message
Charles Kerr (charlesk) wrote :

Marking as Fix Released in indicator-messages and indicator-messages (Ubuntu) based on the branches & context. If I'm mistaken, please reopen the ticket as appropriate. Thanks!

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.