[Classic session] LibreOffice icons are larger than other app's icons

Bug #923932 reported by Fred
26
This bug affects 3 people
Affects Status Importance Assigned to Milestone
LibreOffice
Invalid
Low
gnome-panel (Ubuntu)
Invalid
Undecided
Unassigned
Precise
Invalid
Undecided
Unassigned
libreoffice (Ubuntu)
Won't Fix
Low
Unassigned
Precise
Won't Fix
Undecided
Unassigned

Bug Description

When using gnome-session-fallback (GNOME Classic session / gnome-panel) then LibreOffice icons are much larger image dimensions than the other icons in the menu.
---
ApportVersion: 1.91-0ubuntu1
Architecture: amd64
DistroRelease: Ubuntu 12.04
InstallationMedia: Ubuntu 11.10 "Oneiric Ocelot" - Release amd64 (20111012)
Package: libreoffice
PackageArchitecture: amd64
ProcVersionSignature: Ubuntu 3.2.0-12.21-generic 3.2.2
Tags: precise
Uname: Linux 3.2.0-12-generic x86_64
UpgradeStatus: Upgraded to precise on 2012-01-25 (6 days ago)
UserGroups: adm admin cdrom dialout lpadmin plugdev sambashare

tags: added: bitesize
Revision history for this message
Sebastien Bacher (seb128) wrote :

the issue has nothing to do with gnome-session, likely either gnome-panel rendering or the icon libreoffice provides

no longer affects: gnome-session (Ubuntu)
Revision history for this message
penalvch (penalvch) wrote :

Fred, thank you for reporting this and helping make Ubuntu better. Please execute the following command, as it will automatically gather debugging information, in a terminal:
apport-collect 923932
When reporting bugs in the future please use apport by using 'ubuntu-bug' and the name of the package affected. You can learn more about this functionality at https://wiki.ubuntu.com/ReportingBugs.
As well, could you please attach a screenshot of the LibreOffice icon that demonstrates the problem?

Changed in libreoffice (Ubuntu):
status: New → Incomplete
Revision history for this message
Fred (eldmannen+launchpad) wrote :

Notice how the LibreOffice icons are much larger than Document Viewer and other icons.

Revision history for this message
Fred (eldmannen+launchpad) wrote : Dependencies.txt

apport information

tags: added: apport-collected precise
description: updated
Revision history for this message
Fred (eldmannen+launchpad) wrote : ProcEnviron.txt

apport information

Changed in libreoffice (Ubuntu):
status: Incomplete → New
Revision history for this message
Launchpad Janitor (janitor) wrote : Re: LibreOffice icons classic

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in gnome-panel (Ubuntu):
status: New → Confirmed
Changed in libreoffice (Ubuntu):
status: New → Confirmed
John Kim (epikvision)
Changed in libreoffice (Ubuntu):
assignee: nobody → John Kim (epikvision)
John Kim (epikvision)
Changed in libreoffice (Ubuntu):
assignee: John Kim (epikvision) → nobody
Changed in libreoffice (Ubuntu):
assignee: nobody → Sanchit Gangwar (sanchitgangwar)
status: Confirmed → In Progress
Revision history for this message
Sanchit Gangwar (sanchitgangwar) wrote :

I've looked at the source code and I've found there are no 24x24 or 22x22 icons present. This might be creating the problem because the next available size is 32x32. Should I add new icons?

Changed in libreoffice (Ubuntu):
assignee: Sanchit Gangwar (sanchitgangwar) → nobody
status: In Progress → Confirmed
Changed in libreoffice (Ubuntu):
assignee: nobody → Sanchit Gangwar (sanchitgangwar)
status: Confirmed → In Progress
Revision history for this message
Fred (eldmannen+launchpad) wrote :

I don't know the technical details behind the problem.

Also the menu lags when hovering over the LibreOffice icons in the gnome-panel menu.

Revision history for this message
penalvch (penalvch) wrote :

Sanchit Gangwar, thank you for assigning this bug to yourself.

If you are interested in submitting a patch, could you please do so following http://developer.ubuntu.com/packaging/html/fixing-a-bug.html ?

summary: - LibreOffice icons classic
+ [Classic session] LibreOffice icons are larger than other app's icons
Revision history for this message
Sanchit Gangwar (sanchitgangwar) wrote :

I've added the 24x24 pixels hicolor icons. Patch is attached with the comment and the icons are separately attached.

Changed in libreoffice (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Sanchit Gangwar (sanchitgangwar) wrote :

Here are the icons.

Revision history for this message
Micah Gersten (micahg) wrote :

This is certainly not "Fix Released", see https://wiki.ubuntu.com/Bugs/Status for more information. I believe this should go upstream as binary diffs are difficult to maintain.

Changed in libreoffice (Ubuntu):
status: Fix Released → In Progress
Revision history for this message
Micah Gersten (micahg) wrote :

Bjoern, can you please take care of upstreaming this or help Sanchit do so please.

Changed in libreoffice (Ubuntu):
assignee: Sanchit Gangwar (sanchitgangwar) → Björn Michaelsen (bjoern-michaelsen)
importance: Undecided → Low
status: In Progress → Triaged
Revision history for this message
In , Sanchit Gangwar (sanchitgangwar) wrote :

Created attachment 65566
Screenshot of icons.

When using gnome-session-fallback (GNOME Classic session / gnome-panel) then LibreOffice icons are much larger image dimensions than the other icons in the menu.

Revision history for this message
In , Sanchit Gangwar (sanchitgangwar) wrote :

Created attachment 65566
Screenshot of icons.

When using gnome-session-fallback (GNOME Classic session / gnome-panel) then LibreOffice icons are much larger image dimensions than the other icons in the menu.

Revision history for this message
Sanchit Gangwar (sanchitgangwar) wrote :

Forwarded the bug upstream.

Revision history for this message
In , Michael Meeks (michael-meeks) wrote :

As I recall you(?) were asking on IRC how to help fix it - by installing smaller icons, or somesuch ?

It's entirely possible that our icons are the same size, and simply fill the surrounding bbox too well - where other icons leave space for shadows / other features (?) Or it could be that they are simple larger.

Thoughts / investigation appreciated.

Revision history for this message
In , Michael-meeks-1 (michael-meeks-1) wrote :

As I recall you(?) were asking on IRC how to help fix it - by installing smaller icons, or somesuch ?

It's entirely possible that our icons are the same size, and simply fill the surrounding bbox too well - where other icons leave space for shadows / other features (?) Or it could be that they are simple larger.

Thoughts / investigation appreciated.

Revision history for this message
In , Stefan K. (astron) wrote :

Can confirm on OpenSUSE 12.1... so probably not a Ubuntu packaging bug. We probably really lack a certain icon size.
It's also a bit odd that the menu doesn't force the icon into place... so, maybe it would be a good idea to file the bug at Gnome additionally.

Revision history for this message
In , Stefan K. (astron) wrote :

Can confirm on OpenSUSE 12.1... so probably not a Ubuntu packaging bug. We probably really lack a certain icon size.
It's also a bit odd that the menu doesn't force the icon into place... so, maybe it would be a good idea to file the bug at Gnome additionally.

Revision history for this message
In , Sanchit Gangwar (sanchitgangwar) wrote :

(In reply to comment #1)
> As I recall you(?) were asking on IRC how to help fix it - by installing
> smaller icons, or somesuch ?
>
> It's entirely possible that our icons are the same size, and simply fill the
> surrounding bbox too well - where other icons leave space for shadows / other
> features (?) Or it could be that they are simple larger.
>
> Thoughts / investigation appreciated.

Yes, I'm the same. In fact, I resized the icons to the appropriate size, but the guys at Ubuntu told me to send this bug upstream.

As for the problem, yes, it is genuine. The icons available are 16x16, 32x32, 48x48, and so on. The 24x24 icons are missing, hence the gnome-panel uses 32x32. You need to include 24x24 icons.

Revision history for this message
In , Sanchit Gangwar (sanchitgangwar) wrote :

(In reply to comment #1)
> As I recall you(?) were asking on IRC how to help fix it - by installing
> smaller icons, or somesuch ?
>
> It's entirely possible that our icons are the same size, and simply fill the
> surrounding bbox too well - where other icons leave space for shadows / other
> features (?) Or it could be that they are simple larger.
>
> Thoughts / investigation appreciated.

Yes, I'm the same. In fact, I resized the icons to the appropriate size, but the guys at Ubuntu told me to send this bug upstream.

As for the problem, yes, it is genuine. The icons available are 16x16, 32x32, 48x48, and so on. The 24x24 icons are missing, hence the gnome-panel uses 32x32. You need to include 24x24 icons.

Revision history for this message
penalvch (penalvch) wrote :

Sanchit Gangwar, could you please provide the mailing list URL or FDO bugzilla # where you posted this patch?

Revision history for this message
In , Sanchit Gangwar (sanchitgangwar) wrote :

Created attachment 65624
A proposed patch.

Here is the patch, I created.

Revision history for this message
In , Sanchit Gangwar (sanchitgangwar) wrote :

Created attachment 65624
A proposed patch.

Here is the patch, I created.

Revision history for this message
In , Sanchit Gangwar (sanchitgangwar) wrote :

Created attachment 65625
24x24 icons

These are the 24x24 icons which are currently missing.

Revision history for this message
In , Sanchit Gangwar (sanchitgangwar) wrote :

Created attachment 65625
24x24 icons

These are the 24x24 icons which are currently missing.

Revision history for this message
Sanchit Gangwar (sanchitgangwar) wrote :

FDO Bugzilla #53505

Here is the bug report: https://bugs.freedesktop.org/show_bug.cgi?id=53505.

Changed in df-libreoffice:
importance: Unknown → Low
status: Unknown → Confirmed
Revision history for this message
In , Stefan K. (astron) wrote :

Hi Sanchit,

I am sorry, but your icons are not pixel-aligned -- meaning the horizontal and vertical lines in the icons are rather squishy/fuzzy. It is a better idea to use the official SVG icons from [1], scale the 32*32 icon down and then make sure the everything is aligned neatly. (In Inkscape, you can use the # key to enable the pixel raster. Under View > Icon Preview you can also enable a smaller preview.)
Can you try reworking those icons in this way?

[1] http://wiki.documentfoundation.org/File:LibreOffice_Initial_Icons-pre_final.svg

Revision history for this message
In , Stefan K. (astron) wrote :

Hi Sanchit,

I am sorry, but your icons are not pixel-aligned -- meaning the horizontal and vertical lines in the icons are rather squishy/fuzzy. It is a better idea to use the official SVG icons from [1], scale the 32*32 icon down and then make sure the everything is aligned neatly. (In Inkscape, you can use the # key to enable the pixel raster. Under View > Icon Preview you can also enable a smaller preview.)
Can you try reworking those icons in this way?

[1] http://wiki.documentfoundation.org/File:LibreOffice_Initial_Icons-pre_final.svg

Revision history for this message
In , Sanchit Gangwar (sanchitgangwar) wrote :

Sure I'll submit a patch as soon as possible.

Revision history for this message
In , Sanchit Gangwar (sanchitgangwar) wrote :

Sure I'll submit a patch as soon as possible.

Revision history for this message
In , Sanchit Gangwar (sanchitgangwar) wrote :

Created attachment 67327
24x24 hicolor icons

I've added 24x24 icons again. Please have a look.

Revision history for this message
In , Sanchit Gangwar (sanchitgangwar) wrote :

Created attachment 67327
24x24 hicolor icons

I've added 24x24 icons again. Please have a look.

Benjamin Drung (bdrung)
Changed in gnome-panel (Ubuntu):
status: Confirmed → Invalid
Changed in gnome-panel (Ubuntu Precise):
status: New → Invalid
Revision history for this message
In , Björn Michaelsen (bjoern-michaelsen) wrote :

Comment on attachment 67327
24x24 hicolor icons

@Astron: ping? Could you recheck?

Revision history for this message
In , Björn Michaelsen (bjoern-michaelsen) wrote :

Comment on attachment 67327
24x24 hicolor icons

@Astron: ping? Could you recheck?

Revision history for this message
In , Stefan K. (astron) wrote :

Sorry for not commenting on the new icons before. Somehow, this missed me.

In any case, the revised icons are now of apparently arbitrary sizes, like 19*24 or 26*24 and still don't have proper pixel alignment... so, these aren't better.

Revision history for this message
In , Stefan K. (astron) wrote :

Sorry for not commenting on the new icons before. Somehow, this missed me.

In any case, the revised icons are now of apparently arbitrary sizes, like 19*24 or 26*24 and still don't have proper pixel alignment... so, these aren't better.

Revision history for this message
In , Stefan K. (astron) wrote :

@Björn: could you tell me where these icons need to go in the repo? By accident I just stumbled upon (almost) fitting icons in
  icon-themes/galaxy/res/lx032[42,45,46,47,49,50,51]

All they need is cutting of two pixel of shadow. Oh, and we'd still need the printer admin icon if that thing still exists.

Revision history for this message
In , Stefan K. (astron) wrote :

@Björn: could you tell me where these icons need to go in the repo? By accident I just stumbled upon (almost) fitting icons in
  icon-themes/galaxy/res/lx032[42,45,46,47,49,50,51]

All they need is cutting of two pixel of shadow. Oh, and we'd still need the printer admin icon if that thing still exists.

Revision history for this message
In , Stefan K. (astron) wrote :

^cutting of^cutting off
^pixel^pixels

Revision history for this message
In , Stefan K. (astron) wrote :

^cutting of^cutting off
^pixel^pixels

Revision history for this message
In , Qa-admin-q (qa-admin-q) wrote :

** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

   *Test to see if the bug is still present on a currently supported version of LibreOffice (4.4.1 or later)
   https://www.libreoffice.org/download/

   *If the bug is present, please leave a comment that includes the version of LibreOffice and your operating system, and any changes you see in the bug behavior

   *If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a short comment that includes your version of LibreOffice and Operating System

Please DO NOT

   *Update the version field
   *Reply via email (please reply directly on the bug tracker)
   *Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case)

If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:

1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3)

http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3
. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to "inherited from OOo";
4b. If the bug was not present in 3.3 - add "regression" to keyword

Feel free to come ask questions or to say hello in our QA chat: http://webchat.freenode.net/?channels=libreoffice-qa

Thank you for your help!

-- The LibreOffice QA Team This NEW Message was generated on: 2015-04-18

Revision history for this message
In , Qa-admin-q (qa-admin-q) wrote :

** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present on a currently supported version of LibreOffice
(5.1.5 or 5.2.1 https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the version of LibreOffice and
your operating system, and any changes you see in the bug behavior

If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave
a short comment that includes your version of LibreOffice and Operating System

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not
appropriate in this case)

If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3)

http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3
. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to "inherited from OOo";
4b. If the bug was not present in 3.3 - add "regression" to keyword

Feel free to come ask questions or to say hello in our QA chat: http://webchat.freenode.net/?channels=libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug-20160920

Changed in libreoffice (Ubuntu):
assignee: Björn Michaelsen (bjoern-michaelsen) → nobody
Revision history for this message
Fred (eldmannen+launchpad) wrote :

This is a very old bug, I don't use the flashback session anymore.
But I noticed that Ubuntu 17.04 doesn't have this problem anymore.

Revision history for this message
In , andreas_kainz (kainz-a) wrote :

can someone verify it bug? all app icons are available in 16, 22, 24, 32, 48, 64, 128, 256, 512, 1024 and scalable so this bug should be closed.

Changed in df-libreoffice:
importance: Low → Unknown
status: Confirmed → Unknown
Changed in df-libreoffice:
importance: Unknown → Low
status: Unknown → Invalid
Revision history for this message
Steve Langasek (vorlon) wrote :

The Precise Pangolin has reached end of life, so this bug will not be fixed for that release

Changed in libreoffice (Ubuntu Precise):
status: New → Won't Fix
Changed in libreoffice (Ubuntu):
status: Triaged → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.