Cannot set MAC address via kernel boot parameters

Bug #937051 reported by Paolo Pisati
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
linux-ti-omap4 (Ubuntu)
Fix Released
Undecided
Unassigned
Natty
Won't Fix
Undecided
Unassigned
Oneiric
Won't Fix
Undecided
Unassigned
Precise
Fix Released
Undecided
Unassigned

Bug Description

Smsc95xx lost the ability to change its mac address via kernel boot parameters.

e.g.
smsc95xx.macaddr=0e:c4:a1:33:46:08

What happens in reality is that the nic set the MAC address that we pass in:

drivers/net/usb/smsc95xx.c::smsc95xx_init_mac_address()
...
    /* Check module parameters */
    if (smsc95xx_is_macaddr_param(dev, dev->net->dev_addr))
        return;
...

but the address is invariably overwritten as soon as the interface is created (NETDEV_REGISTER):

arch/arm/mach-omap2/board-omap4panda.c::omap_panda_netdev_event():
...
    n = panda_device_path_need_mac(dev->dev.parent);
    if (n >= 0) {
        sa.sa_family = dev->type;
        omap2_die_id_to_ethernet_mac(sa.sa_data, n);
        dev->netdev_ops->ndo_set_mac_address(dev, &sa);
    }
...

This appeared after Maverick and is going on since then.

Tags: patch
Revision history for this message
Paolo Pisati (p-pisati) wrote :
Revision history for this message
Paolo Pisati (p-pisati) wrote :
tags: added: patch
Tim Gardner (timg-tpi)
Changed in linux-ti-omap4 (Ubuntu Precise):
status: New → Fix Committed
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "0001-smsc95xx-panda-don-t-blindly-overwrite-MAC-address.patch" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (5.7 KiB)

This bug was fixed in the package linux-ti-omap4 - 3.2.0-1407.9

---------------
linux-ti-omap4 (3.2.0-1407.9) precise; urgency=low

  [ Paolo Pisati ]

  * [Config] Enable USB_MUSB_HDRC
    - LP: #927860
  * [Config] Enable led heartbeat
    - LP: #905445
  * rebased on 3.2.0-17.27

  [ Tim Gardner ]

  * [Config] updateconfigs, dropped CONFIG_HAVE_SECCOMP_FILTER,
    CONFIG_SECCOMP_FILTER

  [ Upstream Kernel Changes ]

  * smsc95xx: panda: don't blindly overwrite MAC address
    - LP: #937051

  [ Ubuntu: 3.2.0-17.27 ]

  * SAUCE: drm/i915: fix operator precedence when enabling RC6p

  [ Ubuntu: 3.2.0-17.26 ]

  * [Config] clean up the human consumable package descriptions
  * [Config] fix generic flavour description
  * [Config] clean up linux-tools package descriptions
    - LP: #593107
  * deviations -- note the source of the Hyper-V updates
  * SAUCE: ata_piix: defer to the Hyper-V drivers by default
    - LP: #929545
  * SAUCE: drm/i915: do not enable RC6p on Sandy Bridge
  * SAUCE: (drop after 3.3) security: create task_free security callback
  * SAUCE: (drop after 3.3) security: Yama LSM
  * SAUCE: (drop after 3.3) Yama: add PR_SET_PTRACER_ANY
  * SAUCE: Yama: add link restrictions
  * SAUCE: security: unconditionally chain to Yama LSM
  * Drop ndiswrapper
  * SAUCE: drm/i915: Enable RC6 by default on sandybridge.
  * SAUCE: ipheth: Add iPhone 4S
    - LP: #900802
  * dropped hv_mouse
  * [Config] CONFIG_X86_NUMACHIP=y
  * Staging: hv: vmbus: Support building the vmbus driver as part of the
    kernel
  * hv: Add Kconfig menu entry
  * Drivers: hv: Fix a memory leak
  * Drivers: hv: Make the vmbus driver unloadable
  * Drivers: hv: Get rid of an unnecessary check in hv.c
  * Staging: hv: mousevsc: Make boolean states boolean
  * Staging: hv: mousevsc: Inline the code for mousevsc_on_device_add()
  * Staging: hv: mousevsc: Inline the code for reportdesc_callback()
  * Staging: hv: mousevsc: Cleanup mousevsc_on_channel_callback()
  * Staging: hv: mousevsc: Add a new line to a debug string
  * Staging: hv: mousevsc: Get rid of unnecessary include files
  * Staging: hv: mousevsc: Address some style issues
  * Staging: hv: mousevsc: Add a check to prevent memory corruption
  * Staging: hv: mousevsc: Use the KBUILD_MODNAME macro
  * Staging: hv: storvsc: Use mempools to allocate struct
    storvsc_cmd_request
  * Staging: hv: storvsc: Cleanup error handling in the probe function
  * Staging: hv: storvsc: Fixup the error when processing SET_WINDOW
    command
  * Staging: hv: storvsc: Fix error handling storvsc_host_reset()
  * Staging: hv: storvsc: Use the accessor function shost_priv()
  * Staging: hv: storvsc: Use the unlocked version queuecommand
  * Staging: hv: storvsc: use the macro KBUILD_MODNAME
  * Staging: hv: storvsc: Get rid of an unnecessary forward declaration
  * Staging: hv: storvsc: Upgrade the vmstor protocol version
  * Staging: hv: storvsc: Support hot add of scsi disks
  * Staging: hv: storvsc: Support hot-removing of scsi devices
  * staging: hv: Use kmemdup rather than duplicating its implementation
  * staging: hv: move hv_netvsc out of staging area
  * Staging: hv: mousevsc: Properly add the hid device
  * Staging...

Read more...

Changed in linux-ti-omap4 (Ubuntu Precise):
status: Fix Committed → Fix Released
Revision history for this message
Rolf Leggewie (r0lf) wrote :

natty has seen the end of its life and is no longer receiving any updates. Marking the natty task for this ticket as "Won't Fix".

Changed in linux-ti-omap4 (Ubuntu Natty):
status: New → Won't Fix
Revision history for this message
Rolf Leggewie (r0lf) wrote :

oneiric has seen the end of its life and is no longer receiving any updates. Marking the oneiric task for this ticket as "Won't Fix".

Changed in linux-ti-omap4 (Ubuntu Oneiric):
status: New → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.