ftfbs on armhf

Bug #944709 reported by Marcin Juszkiewicz
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
xf86-video-msm (Debian)
Fix Released
Unknown
xf86-video-msm (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Package ftfbs on armhf due to use of wrong compiler flags.

Revision history for this message
Marcin Juszkiewicz (hrw) wrote :
Changed in xf86-video-msm (Ubuntu):
status: New → Triaged
Revision history for this message
Fabrice Coutadeur (fabricesp) wrote :

Hi Marcin,

I've seen some additional changes in the patch sent to Debian, especially the part changing the control file, to add armhf to the packages. Could you please do the following changes to your defdiff:
- add a DEP3 header to the patch (giving credit to the creator of this patch)
- Add justification why you are dropping an upstream cflag (the explanation given in the debian bug seems fine) in the patch header
- change debian/control so that the packages can be installed on armhf.

generally speaking, it's worth checking Debian PTS before submitting a patch to Ubuntu, to check if a solution has already been given or not.

Anyway, thanks a lot for your work!

Fabrice

Changed in xf86-video-msm (Ubuntu):
status: Triaged → Incomplete
Revision history for this message
Marcin Juszkiewicz (hrw) wrote :

This debdiff has those changes:

- patch got renamed to 03_fix_FTFB_for_armhf.patch
- patch got DEP3 header with description what it does and why

debian/control is not patched as it contains armhf already (contrary to Debian)

Changed in xf86-video-msm (Ubuntu):
status: Incomplete → Opinion
Revision history for this message
Fabrice Coutadeur (fabricesp) wrote :

Uploaded as-is! Thank you very much for your work!

Thanks,
Fabrice

Changed in xf86-video-msm (Ubuntu):
status: Opinion → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package xf86-video-msm - 1.0.1+git20100122.5f7df591-1ubuntu2

---------------
xf86-video-msm (1.0.1+git20100122.5f7df591-1ubuntu2) precise; urgency=low

  * Strip float-abi compiler option to fix FTFBS on armhf - LP: #944709
 -- Marcin Juszkiewicz <email address hidden> Tue, 28 Feb 2012 11:48:35 +0100

Changed in xf86-video-msm (Ubuntu):
status: Fix Committed → Fix Released
Changed in xf86-video-msm (Debian):
status: Unknown → New
Changed in xf86-video-msm (Debian):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.