Ubuntu
vnc4 package

vnc4 version 4.1.1+xorg4.3.0-37ubuntu4 failed to build on armhf

Bug #945368 reported by Ricardo Salveti
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
vnc4 (Debian)
Fix Released
Unknown
vnc4 (Ubuntu)
Fix Released
High
Unassigned

Bug Description

vnc4 version 4.1.1+xorg4.3.0-37ubuntu4 failed to build on armhf
Link to failed build: https://launchpad.net/ubuntu/+source/vnc4/4.1.1+xorg4.3.0-37ubuntu4/+build/3188532

Direct link to the build log: https://launchpad.net/ubuntu/+source/vnc4/4.1.1+xorg4.3.0-37ubuntu4/+build/3188532/+files/buildlog_ubuntu-precise-armhf.vnc4_4.1.1%2Bxorg4.3.0-37ubuntu4_FAILEDTOBUILD.txt.gz

This log snippet might be of interest, since it triggered the matcher 'Purging chroot-autobuild'.
Excerpt 42661 lines into the build log:

rm -f Xserver.1x.html Xserver.1x-html
../../config/util/rman -f HTML < Xserver._man \
   > Xserver.1x-html && mv -f Xserver.1x-html Xserver.1x.html
macro "in" not recognized -- ignoring
make[5]: Leaving directory `/build/buildd/vnc4-4.1.1+xorg4.3.0/unix/xc/programs/Xserver'
make[4]: *** [all] Error 2
make[4]: Leaving directory `/build/buildd/vnc4-4.1.1+xorg4.3.0/unix/xc/programs'
make[3]: *** [all] Error 2
make[3]: Leaving directory `/build/buildd/vnc4-4.1.1+xorg4.3.0/unix/xc'
make[2]: *** [World] Error 2
make[2]: Leaving directory `/build/buildd/vnc4-4.1.1+xorg4.3.0/unix/xc'
make[1]: *** [World] Error 2
make[1]: Leaving directory `/build/buildd/vnc4-4.1.1+xorg4.3.0/unix/xc'
make: *** [build-arch-x-stamp] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2
******************************************************************************
Build finished at 20120205-2050
FAILED [dpkg-buildpackage died]
Purging chroot-autobuild/build/buildd/vnc4-4.1.1+xorg4.3.0

Ricardo Salveti (rsalveti)
Changed in vnc4 (Ubuntu):
status: New → Confirmed
importance: Undecided → High
Bug Watch Updater (bug-watch-updater)
Changed in vnc4 (Debian):
status: Unknown → New
Revision history for this message
Bryce Harrington (bryce) wrote :

This looks bad too:

In file included from xf86sym.c:145:0:
/usr/include/arm-linux-gnueabihf/sys/io.h:38:22: error: conflicting types for 'inb'
../../../../../programs/Xserver/hw/xfree86/common/compiler.h:879:1: note: previous definition of 'inb' was here
/usr/include/arm-linux-gnueabihf/sys/io.h:39:27: error: conflicting types for 'inw'
../../../../../programs/Xserver/hw/xfree86/common/compiler.h:885:1: note: previous definition of 'inw' was here
/usr/include/arm-linux-gnueabihf/sys/io.h:40:26: error: conflicting types for 'inl'
../../../../../programs/Xserver/hw/xfree86/common/compiler.h:891:1: note: previous definition of 'inl' was here
/usr/include/arm-linux-gnueabihf/sys/io.h:42:13: error: conflicting types for 'outb'
../../../../../programs/Xserver/hw/xfree86/common/compiler.h:861:1: note: previous definition of 'outb' was here
/usr/include/arm-linux-gnueabihf/sys/io.h:43:13: error: conflicting types for 'outw'
../../../../../programs/Xserver/hw/xfree86/common/compiler.h:867:1: note: previous definition of 'outw' was here
/usr/include/arm-linux-gnueabihf/sys/io.h:44:13: error: conflicting types for 'outl'
../../../../../programs/Xserver/hw/xfree86/common/compiler.h:873:1: note: previous definition of 'outl' was here
make[7]: *** [xf86sym.o] Error 1

Revision history for this message
Bryce Harrington (bryce) wrote :

Yep, the errors from my previous comment are why this isn't building.

vnc4 has an old copy of the Xserver included in it. The file unix/xc/programs/Xserver/hw/xfree86/common/compiler.h includes definitions for inw(), inb() which conflict with ones provided in sys/io.h on arm.

Current Xserver's compiler includes preprocessor conditions to hide the declarations. It also includes this comment to explain what it's doing:

#elif defined(__arm__) && defined(__linux__)
/* for Linux on ARM, we use the LIBC inx/outx routines */
/* note that the appropriate setup via "ioperm" needs to be done */
/* *before* any inx/outx is done. */
#include <sys/io.h>
...

So, it looks to me like this code needs to be ported over to vnc4's compiler.h.

Theoretically should be straightforward work, but I've got some higher priority items I need to tend to first so if anyone else wants to take a stab at it, go for it.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package vnc4 - 4.1.1+xorg4.3.0-37ubuntu5

---------------
vnc4 (4.1.1+xorg4.3.0-37ubuntu5) raring; urgency=low

  * Add armhf_inw_inb.patch: Define compiler macros for armhf platform.
    Fixes FTBS on armhf.
    (LP: #945368)
 -- Bryce Harrington <email address hidden> Thu, 10 Jan 2013 17:07:37 -0800

Changed in vnc4 (Ubuntu):
status: Confirmed → Fix Released
Bug Watch Updater (bug-watch-updater)
Changed in vnc4 (Debian):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.