[camera/still] window that opens to display still image doesn't close

Bug #990133 reported by Jeff Lane 
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Checkbox
Fix Released
Low
Sylvain Pineau
checkbox (Ubuntu)
Fix Released
Undecided
Unassigned
Precise
Fix Released
Undecided
Unassigned

Bug Description

[Impact]
When camera/video runs, the window that displays the live video capture is automatically closed after so many seconds. When camera/still runs, that window does not close automatically. There's nothing in the description indicating that it needs to be manually closed, and since the video one closes automatically, that creates the assumption that one should wait for the still image to close as well.

This is fixed in development by using the timeout command to close the window after a few seconds.

[Test case]
- Ensure xawtv is installed (to detect the camera)
- Start checkbox-qt
- Right-click on the list of tests, then select "Deselect all".
- Select only the "camera" tests.
- Click "start testing".
- Skip (by clicking "Next") the camera/display test.
- On the camera/still test, click "Test".
- A window with the captured image will appear over the checkbox window and remain until manually closed.

[Regression potential]
The timeout command which was added to this script is part of the coreutils package, and can be reasonably expected to exist in any Ubuntu system, so the code should not introduce regressions as long as this is available.

About the only potential issue is that the test string does not change and so the user has no indication that the window will close after a while. This can still be confusing but the confusion should only last for as long as the window remains open (10 seconds).

Related branches

Changed in checkbox:
status: New → Confirmed
assignee: nobody → Sylvain Pineau (sylvain-pineau)
importance: Undecided → Low
Changed in checkbox:
status: Confirmed → In Progress
Changed in checkbox:
status: In Progress → Fix Committed
Daniel Manrique (roadmr)
description: updated
Changed in checkbox:
status: Fix Committed → Fix Released
Revision history for this message
Clint Byrum (clint-fewbar) wrote : Please test proposed package

Hello Jeff, or anyone else affected,

Accepted checkbox into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/checkbox/0.13.8 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in checkbox (Ubuntu Precise):
status: New → Fix Committed
tags: added: verification-needed
Daniel Manrique (roadmr)
Changed in checkbox (Ubuntu):
status: New → Fix Released
Revision history for this message
Daniel Manrique (roadmr) wrote :

I tested this on a Precise system with xawtv installed. Checkbox 0.13.7 is present first. I launched checkbox-qt, deselected all tests, and selected only the camera category (3 tests). Then I started the run:

- First test to come up is camera/display. I click "test". A live video window opens, then closes after about 10 seconds. I clicked on "Yes" to mark the test as passed.
- Next comes camera/still. A capture window with a picture of me (heh) comes up. No indication I have to do anything, and the window remains there. I counted 30 seconds, then closed the window. Marked the test as passed.
- The test run ends and I get to the report screen, but it's not relevant to this fix so I just closed checkbox.

I then upgraded checkbox and checkbox-qt to 0.13.8 from -proposed. I used the same procedure as above:
- First test to come up is camera/display. I click "test"Behaves as before, opening a video window and closing automatically after 10 seconds. I clicked on "Yes" to mark the test as passed.
- Next comes camera/still. A capture window with a picture of me (heh) comes up. No indication I have to do anything, and the window remains there. I counted 30 seconds, then closed the window. This constitutes a FAILURE because the window was supposed to close after 10 seconds.

Upon closer inspection of the code, I see that we call eog in two different places. This is because we try calling v4lctl first (first call to eog; I didn't apply the fix here). If v4lctl (which comes with xawtv) is not installed, we fall back to using gstreamer to capture the image (this is where I applied the fix).

A default Ubuntu system will not have xawtv installed, so I removed xawtv and tried to run the test again. I realized that the entire fallback code has two problems and doesn't work: first, the exception raised when v4lctl is not present is not CalledProcessError, but OSError (which we're not catching). Then, the call() where we invoke eog uses filename, which is not defined (should be file.name).

So all in all the fix was applied in the wrong place and does not work, I have unfortunately to mark this as verification-failed.

Thanks!

tags: added: verification-failed
removed: verification-needed
Revision history for this message
Steve Langasek (vorlon) wrote :

Hello Jeff, or anyone else affected,

Accepted checkbox into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/checkbox/0.13.9 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: removed: verification-failed
tags: added: verification-needed
Adam Conrad (adconrad)
Changed in checkbox (Ubuntu Precise):
status: Fix Committed → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package checkbox - 0.13.9

---------------
checkbox (0.13.9) precise-proposed; urgency=low

  * Updated fix for bug #1026614 which was missing some code.
  * Removed bad fix for bug 990133.

checkbox (0.13.8) precise-proposed; urgency=low

  * New upstream release (LP: #1061198)

  [Marc Tardif]
  * checkbox/dispatcher.py: Updated license to GPLv3 to be consistent with
    rest of Checkbox files (LP: #1049881)

  [Sylvain Pineau]
  * qt/frontend/qtfront.ui: Fixed the test purpose widget size to allow two
    lines of description (LP: #1032255)
  * scripts/camera_test, jobs/camera.txt.in: Added a 10s timeout to the camera
    still test (LP: #990133)

  [Daniel Manrique]
  * jobs/audio.txt.in: replaced gconfaudiosink by autoaudiosink (LP: #978895)
  * Instruct Chromium browser to accept file:// URLs so it can correctly
    open the checkbox submission.xml report (LP: #1026614)
  * scripts/network_check: InvalidURL exception is caught and handled more
    cleanly (LP: #751701)
  * Set the correct user (root) for fwts-wakealarm test (LP: #1004102)
  * Set correct user (root) for usb/storage-preinserted, so it works correctly
    on servers (LP: #1004131)

  [Nathan Williams]
  * scripts/network_check: Fixed exception handling in the absence of zenity
    (LP: #988260)
 -- Daniel Manrique <email address hidden> Tue, 20 Nov 2012 16:31:02 -0500

Changed in checkbox (Ubuntu Precise):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.