Comment 6 for bug 321848

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

Hi Colin, Kees had a quick look at this and seems happy with it:

(18:01:07) chrisccoulson: cool. upstream removed the ability to build it without ncurses in the new version, and i was going to ask if you could review a patch colin watson just did to make this to work again
(18:01:13) chrisccoulson: bug 321848
(18:01:14) ubottu: Launchpad bug 321848 in vte "libvte9-udeb depends on libncurses5" [Undecided,New] https://launchpad.net/bugs/321848
(18:01:40) chrisccoulson: it builds with the correct dependencies, but it needs a sanity check from someone who's slightly more familiar
(18:02:44) kees: sure, do you have a straight diff of the change somewhere?
(18:04:14) chrisccoulson: its in bzr, but I just posted the actual patch in debian/patches here: http://paste.ubuntu.com/110373/
(18:04:49) chrisccoulson: the configure.in change was already in the last version, but colin modified it as I made a mistake (which is why it ended up being linked against ncurses)
(18:05:06) chrisccoulson: the other source changes look very similar to what was already in the old version
(18:06:24) kees: chrisccoulson: that patch looks fine to me. Hopefully upstream will take it.
(18:06:47) chrisccoulson: it would be nice, but they already removed this functionality from the new version :(
(18:06:58) chrisccoulson: hence the new patch to add it back in again