Merge lp:~jamesodhunt/upstart/bug-901038 into lp:upstart
Proposed by
James Hunt
Status: | Merged |
---|---|
Merged at revision: | 1664 |
Proposed branch: | lp:~jamesodhunt/upstart/bug-901038 |
Merge into: | lp:upstart |
Diff against target: |
123 lines (+77/-16) (has conflicts) 2 files modified
ChangeLog (+15/-0) util/telinit.c (+62/-16) Text conflict in ChangeLog |
To merge this branch: | bzr merge lp:~jamesodhunt/upstart/bug-901038 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Steve Langasek | Approve | ||
Review via email: mp+231705@code.launchpad.net |
To post a comment you must log in.
Should there be some kind of timeout, say a minute or so to catch the unlikely case where upstart is messed up an never starts listening again on dbus?
Also, you mention that a rejected reexec request is unlikely, but what happens if a non-root user does it, wouldn't that fail and then have the rest of the code return success anyway?