Merge lp:~mterry/lightdm/initialize-more into lp:lightdm
Proposed by
Michael Terry
Status: | Merged |
---|---|
Merged at revision: | 2322 |
Proposed branch: | lp:~mterry/lightdm/initialize-more |
Merge into: | lp:lightdm |
Diff against target: |
50 lines (+6/-8) 2 files modified
src/greeter-session.c (+0/-6) src/unity-system-compositor.c (+6/-2) |
To merge this branch: | bzr merge lp:~mterry/lightdm/initialize-more |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Robert Ancell | Approve | ||
PS Jenkins bot | continuous-integration | Pending | |
Review via email: mp+296836@code.launchpad.net |
Commit message
Be more careful about closing uninitialized memory.
Description of the change
Be more careful about closing uninitialized memory.
It caused problems for Josh and me:
- lightdm calls close(0) because of unintialized/
- pipe() and similar methods are happy to give back fd=0 now
- lightdm may provide USC with --from-dm-fd=0 because it got back 0 from pipe
- USC can't actually write to fd=0 because that's its stdin and isn't inherited like other fds
- USC aborts because it can't open from-dm-fd for writing
Thanks to Josh for finding this fix with me.
To post a comment you must log in.
Thanks guys!