OpenStack Compute (nova)

wrong flavorid to instance_type_id translation

Bug #1010638 reported by Brian Lamar on 2012-06-08

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Compute (nova)	Fix Released	Undecided	Brian Lamar	OpenStack Compute (nova) 2012.2 "folsom"

Bug Description

When OSAPI create() recieves a request for a new server, one of the first things it does is check to see if the flavorid given is valid. Recent changes have made it so that this check receives incorrect information in the form of deleted instance_types. Basically what is happening is:

-Administrator creates flavor with name "flavor1" and flavorid "1"
-Administrator marks flavor with name "flavor 1" as deleted
-Administrator creates flavor with name "flavor1-redux" and flavorid "1"

instance_types.get_instance_type_by_flavorid("1") will now return "flavor1" instead of the non-deleted "flavor1-redux"

Brian Lamar (blamar) on 2012-06-08

Changed in nova:
assignee:	nobody → Brian Lamar (blamar)
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2012-06-08: Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/8355

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2012-06-10: Fix merged to nova (master)

Reviewed: https://review.openstack.org/8355
Committed: http://github.com/openstack/nova/commit/5157401f20158b2b99d01796f73a8ba5368c80a2
Submitter: Jenkins
Branch: master

commit 5157401f20158b2b99d01796f73a8ba5368c80a2
Author: Brian Lamar <email address hidden>
Date: Fri Jun 8 15:18:13 2012 -0400

Do not always query deleted instance_types.

    When converting from flavorid to instance_type_id in the OSAPI,
    it isn't always desired to return deleted instance_types. In the case
    of OSAPI create(), we explicitly do not want to query deleted flavors.

Fixes bug 1010638

Change-Id: I9c26c7130f8c3d6680143e36b4aaa1f662c682a7