Service Request: Squeezebox

> I recently bought a Squeezebox and thought it'd make a great addition to
> Nuvola.

New service integrations are always welcome, thanks for your work.

> Unfotunately, I couldn't get the bzr to run due the webkit bug
> so I just hacked a new service into the PPA version, files are attached.

Could you please use lp:nuvola-player/releases-1.x as a base branch
instead of lp:nuvola-player, integrate your files, upload you branch
to Launchpad and link it to this bug?

> * The code uses localhost by default as that's where most people have the squeezebox server installed but many (including me) do not, is there any way to make that a setting?

Unfortunately Nuvola Player currently does not support services with a
configurable streaming server address (bug #1011097).

> * The album art isn't working correctly despite the variable being set correctly, starting to think it might be a server bug.

It may be a bug #987464.

> * The interface displays artists sometimes in the form of $band, $songwriter and sometimes vice versa, so can sometimes pick the wrong artist to display.

I think it is not a big deal. Is it possible to contact Squeezebox
developers about this issue?

  status triaged
  importance wishlist
  tag service-integration bug-dependency
  milestone patches-welcome
  summary "Service Integration: Squeezebox"

Currently selecting the Squeezebox service without Squeezebox installed or running on a different address would lead to error (server not found) and user might be confused. It is necessary to create local HTML page that would the tell user that this integration requires his own instance of Squezebox and provide a form to set up the address to that instance. See also bug #1011097.

Development version already allows to set local HTML page. However, in order to continue, Squeezebox integration has to be ported to NuvolaPlayer JavaScript API 2.0.

Kieran Hogg, could you port your integration to the API 2.0? More information at https://lists.launchpad.net/nuvola-player-devel/msg00017.html and http://nuvolaplayer.fenryxo.cz/Contribute/Development/JavaScript_API.html

I forgot to mention I've created a shared branch lp:~nuvola-player-devel/nuvola-player/squeezebox

If you are in a team https://launchpad.net/~nuvola-player-devel, you should have a commit access to this branch.

Since development of Nuvola Player has been discontinued [1], I'm closing the bug tracker. It will be reopened when a new maintainer is found. I'm sorry I wasn't able to address this issue.

[1] https://launchpad.net/nuvola-player/+announcement/11960

I created an integration with the 2.0 api and created an option to switch the address of the server. I hope the the solution is not too ugly.

Small fix for my integration.js

Fix for fix

Hi Steffen. I'm sorry for late reply. I am currently busy with release
2.3 and I'll take a look at your work after it.

Code review:

== description.html

Please wrap lines to 100 characters.

== metadata.conf

     5 sandbox_pattern = .*/nuvolaplayer/services/lms/home.html|https?://.*

This won't work if service in integration is in directory /tmp/foo/lms and Nuvola Player is run with `--services-dir=/tmp/foo`. Use `sandbox_pattern = file://.*|https?://.*`.

== integration.js

Use tabs (width 4 chars) for indentation.

74 var can_prev;
75 var can_next;

You didn't use these variables. Are previsous/next song actions always available?

== settings.js

I've rewritten this script to use host/port entries and apply/reset buttons. Please check proper functionality.

Your solution works well, the settings look much better now. I will do the rest in the next days. Thank you for your time :)

Forgot to upload. Sorry. Works quite well now and prev/next can be handled as always avaible.

I've made following changes. Do you agree with them?

=== modified file 'data/nuvolaplayer/services/lms/integration.js'
--- data/nuvolaplayer/services/lms/integration.js 2014-02-25 16:35:27 +0000
+++ data/nuvolaplayer/services/lms/integration.js 2014-02-25 16:36:27 +0000
@@ -55,8 +55,8 @@

   /* Let's run */
   this.state = Nuvola.STATE_NONE;
- this.can_prev = true;
- this.can_next = true;
+ Nuvola.updateAction(Nuvola.ACTION_PREV_SONG, true);
+ Nuvola.updateAction(Nuvola.ACTION_NEXT_SONG, true);
   this.update();
  };

@@ -70,8 +70,6 @@
   var album_art = null;
   var artist = null;
   var song = null;
- var can_prev;
- var can_next;

   try{
    var album_object = document.getElementById('ctrlCurrentArt').children[0];

Yes, thanks for your patience. It all works well now.

> Yes, thanks for your patience.

No problem, you are helping to make Nuvola Player better.

> It all works well now.

Great, I'm ready to accept and publish your service integration as soon as you are subscribed to the Nuvola Player Development mailing list at [1]. It has low traffic. Please notify me when you are subscribed.

[1] https://launchpad.net/~nuvola-player-devel

I have subcribed to the mailing list now.