import babel in setup.py breaks linux installs

Bug #1017120 reported by Christophe Combelles
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Odoo Server (MOVED TO GITHUB)
Fix Released
Low
OpenERP's Framework R&D

Bug Description

The setup.py file contains both an "import babel" and a babel requirement.
When running the setup, babel should be installed as a dependency and should not be required by the setup itself.
This seems to be done to workaround a bug in windows with py2exe.
However on Linux we don't need this workaround : the workaround for windows is turned into a bug for linux.

I suggest to move the "import babel" in the "if" block for windows (as it was probably intended to be done) :

setup.py:41 :

    if os.name == 'nt':
        r.append(("Microsoft.VC90.CRT", glob.glob('C:\Microsoft.VC90.CRT\*.*')))

        import babel
        r.append(("localedata",
                  glob.glob(os.path.join(os.path.dirname(babel.__file__), "localedata" , '*'))))

Related branches

Revision history for this message
Christophe Combelles (ccomb) wrote :

crosslinking an issue in the buildout recipe which is related to this problem :
https://bugs.launchpad.net/anybox.recipe.openerp/+bug/1014066

Changed in openobject-server:
status: New → Fix Committed
status: Fix Committed → New
Revision history for this message
Amit Parik (amit-parik) wrote :

Hello Chrisophe,

Yes, you are right. Import babel only require on windows version at setup.py and I agreed with your solution.

So I am assigning this as a "Low" priority.
If you want to contribute on OpenERP the would you please create a stack branch for server project and commit your changes/fixes. Then put the merge purposal(MP) for trunk branch and our core team will review it.

That's better if you providing a MP instead of giving solution on bug which is also easy for us.

Hope you are understand and start to contribute on OpenERP.

Thank you!

Changed in openobject-server:
assignee: nobody → OpenERP's Framework R&D (openerp-dev-framework)
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
Olivier Dony (Odoo) (odo-openerp) wrote :

Your suggested fix was applied in trunk at server r.4643 rev-id: <email address hidden>

Thanks for reporting!

Changed in openobject-server:
milestone: none → 7.0
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.