ltsp: screen session "ssh" not working in precise

Can you try replacing
    "$script_path" "$args"
with
    "$script_path" $args
in line 78 of /opt/ltsp/i386/usr/share/ltsp/screen_session,
then running ltsp-update-image, and finally rebooting your client?

Better yet, could you try this patch instead?

=== modified file 'client/share/ltsp/screen_session'
--- client/share/ltsp/screen_session 2012-05-14 19:23:51 +0000
+++ client/share/ltsp/screen_session 2012-07-02 21:19:18 +0000
@@ -56,9 +56,9 @@
         eval $(getltscfg-cluster -a -l prompt)
     fi

- read script args <<EOF
-$(eval echo "\$SCREEN_$num")
-EOF
+ set -- $(eval "echo \$SCREEN_$num")
+ script=$1
+ shift

     # Screen scripts in /etc override those in /usr
     unset script_path
@@ -75,7 +75,7 @@
     for script in $(run_parts_list /usr/share/ltsp/screen-session.d/ S); do
         . "$script"
     done
- "$script_path" "$args"
+ "$script_path" "$@"
     for script in $(run_parts_list /usr/share/ltsp/screen-session.d/ K); do
         . "$script"
     done

Alkis, your patch does the trick! Works like expected, thank you!

This bug is still present in quantal. The above patch works fine, could someone uplpoad ist to {precise,quantal}-updates?

This bug is solved, patch exists and is tested.
What am I to do to get this report into state "Fix commited"?

Someone needs to commit it upstream, upstream needs to make a release, that release needs to get into the Ubuntu development release, then the fix can be pushed to -updates for older releases.

How can I trigger this process?

Please read this as: "I'd like to help, but don't know how to."

Hi Rüdiger,

the problem with the screen scripts is that some of them are using a single escaped string + eval to pass the parameters to xinit, and some are using "$@", multiple parameters. And xinit has problems if one of the parameters is "--", because it has a special meaning for that. And xfreerdp is also using "--" to separate the plugin parameters, and things start to get confusing (we've had bugs there before).

So personally I was waiting to have some free time to get through all the screen scripts code and fix all similar bugs at once, rather than fixing them individually. It other words the patch above should be fine for all screen scripts, but I'd like to do some tests with difficult command lines like xfreerdp <params> -- --plugin <plugin params> -- --other-plugin <other-plugin-params> before I feel confident enough to push the fix. Of course other devs may get some free time before me and test/commit the fix earlier.

Hello Alkis,

I understand. Thank you for working so thoroughly on the problem.
Please let me know when I can be of any help.

Bug #1175618 reports the same problem for the xdmcp session script. I suggest committing the patch above to the sources.

Fixed/worked around in:

https://bazaar.launchpad.net/~ltsp-upstream/ltsp/ltsp-trunk/revision/2598

This bug was fixed in the package ltsp - 5.5.4-4ubuntu1

---------------
ltsp (5.5.4-4ubuntu1) wily; urgency=medium

  * Merge from Debian. Remaining changes:
   - Use fonts-guru instead of ttf-punjabi-fonts
   - Include the getltscfg-cluster manpage
   - Edubuntu support code in ltsp postinst

 -- Stephane Graber <email address hidden> Mon, 08 Jun 2015 11:33:04 +0200

Fix released in LTSP 5.5.4.