pep8 tests failing for tests/*py

Bug #1022575 reported by Derek Higgins
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Undecided
Derek Higgins

Bug Description

commit 39b20acc933cb0fdf73075ddb9a9d82665b84b23 updates the version of pep8 to 1.3.3
commit 04df79b64e5f2296df03579700535774e158f623 turns on pep8 tests for the tests directory

both together throw up around 100 pep8 errors

[derekh@fido keystone]$ ./tools/with_venv.sh ./run_tests.sh -p | grep tests | grep ": E"
tests/default_fixtures.py:21:5: E123 closing bracket does not match indentation of opening bracket's line
tests/default_fixtures.py:31:5: E123 closing bracket does not match indentation of opening bracket's line
tests/default_fixtures.py:36:5: E123 closing bracket does not match indentation of opening bracket's line
tests/default_fixtures.py:41:5: E123 closing bracket does not match indentation of opening bracket's line
tests/test_backend.py:48:17: E126 continuation line over-indented for hanging indent
tests/test_backend.py:49:17: E126 continuation line over-indented for hanging indent
tests/test_backend.py:60:17: E126 continuation line over-indented for hanging indent
tests/test_backend.py:61:17: E126 continuation line over-indented for hanging indent
tests/test_backend.py:62:17: E126 continuation line over-indented for hanging indent
tests/test_backend.py:75:17: E126 continuation line over-indented for hanging indent
tests/test_backend.py:76:17: E126 continuation line over-indented for hanging indent
tests/test_backend.py:77:17: E126 continuation line over-indented for hanging indent
tests/test_backend.py:102:17: E126 continuation line over-indented for hanging indent
tests/test_backend.py:130:17: E126 continuation line over-indented for hanging indent
tests/test_backend.py:144:17: E126 continuation line over-indented for hanging indent
tests/test_backend.py:145:17: E126 continuation line over-indented for hanging indent
tests/test_backend.py:162:17: E126 continuation line over-indented for hanging indent
tests/test_backend.py:183:17: E128 continuation line under-indented for visual indent
tests/test_backend.py:185:17: E128 continuation line under-indented for visual indent
tests/test_backend.py:541:17: E128 continuation line under-indented for visual indent
tests/test_backend.py:543:17: E128 continuation line under-indented for visual indent
tests/test_backend.py:562:17: E128 continuation line under-indented for visual indent
tests/test_backend.py:576:13: E128 continuation line under-indented for visual indent
tests/test_backend.py:583:17: E128 continuation line under-indented for visual indent
tests/test_backend.py:585:17: E128 continuation line under-indented for visual indent
tests/test_backend.py:601:17: E126 continuation line over-indented for hanging indent
tests/test_backend_ldap.py:59:17: E128 continuation line under-indented for visual indent
tests/test_backend_ldap.py:61:17: E128 continuation line under-indented for visual indent
tests/test_backend_templated.py:29:33: E126 continuation line over-indented for hanging indent
tests/test_backend_templated.py:30:37: E126 continuation line over-indented for hanging indent
tests/test_content_types.py:74:17: E126 continuation line over-indented for hanging indent
tests/test_content_types.py:75:17: E126 continuation line over-indented for hanging indent
tests/test_content_types.py:76:17: E126 continuation line over-indented for hanging indent
tests/test_content_types.py:127:13: E128 continuation line under-indented for visual indent
tests/test_content_types.py:141:13: E128 continuation line under-indented for visual indent
tests/test_content_types.py:229:17: E126 continuation line over-indented for hanging indent
tests/test_content_types.py:236:13: E123 closing bracket does not match indentation of opening bracket's line
tests/test_content_types.py:345:17: E126 continuation line over-indented for hanging indent
tests/test_content_types.py:352:13: E123 closing bracket does not match indentation of opening bracket's line
tests/test_content_types.py:359:13: E128 continuation line under-indented for visual indent
tests/test_content_types.py:365:17: E126 continuation line over-indented for hanging indent
tests/test_content_types.py:366:13: E123 closing bracket does not match indentation of opening bracket's line
tests/test_content_types.py:394:17: E126 continuation line over-indented for hanging indent
tests/test_content_types.py:395:13: E123 closing bracket does not match indentation of opening bracket's line
tests/test_content_types.py:404:17: E126 continuation line over-indented for hanging indent
tests/test_content_types.py:405:13: E123 closing bracket does not match indentation of opening bracket's line
tests/test_content_types.py:412:17: E126 continuation line over-indented for hanging indent
tests/test_content_types.py:413:13: E123 closing bracket does not match indentation of opening bracket's line
tests/test_content_types.py:422:17: E126 continuation line over-indented for hanging indent
tests/test_content_types.py:423:13: E123 closing bracket does not match indentation of opening bracket's line
tests/test_content_types.py:440:17: E126 continuation line over-indented for hanging indent
tests/test_content_types.py:441:13: E123 closing bracket does not match indentation of opening bracket's line
tests/test_content_types.py:570:17: E126 continuation line over-indented for hanging indent
tests/test_content_types.py:573:21: E123 closing bracket does not match indentation of opening bracket's line
tests/test_content_types.py:574:17: E123 closing bracket does not match indentation of opening bracket's line
tests/test_content_types.py:601:17: E126 continuation line over-indented for hanging indent
tests/test_keystoneclient.py:238:28: E127 continuation line over-indented for visual indent
tests/test_keystoneclient.py:344:37: E126 continuation line over-indented for hanging indent
tests/test_keystoneclient.py:373:19: E128 continuation line under-indented for visual indent
tests/test_keystoneclient.py:374:19: E128 continuation line under-indented for visual indent
tests/test_keystoneclient.py:375:19: E128 continuation line under-indented for visual indent
tests/test_keystoneclient.py:871:17: E126 continuation line over-indented for hanging indent
tests/test_keystoneclient.py:877:17: E126 continuation line over-indented for hanging indent
tests/test_keystoneclient.py:880:17: E125 continuation line does not distinguish itself from next logical line
tests/test_keystoneclient.py:889:17: E126 continuation line over-indented for hanging indent
tests/test_keystoneclient.py:926:19: E128 continuation line under-indented for visual indent
tests/test_keystoneclient.py:927:19: E128 continuation line under-indented for visual indent
tests/test_keystoneclient.py:928:19: E128 continuation line under-indented for visual indent
tests/test_keystoneclient_sql.py:32:17: E126 continuation line over-indented for hanging indent
tests/test_keystoneclient_sql.py:33:17: E126 continuation line over-indented for hanging indent
tests/test_keystoneclient_sql.py:34:17: E126 continuation line over-indented for hanging indent
tests/test_middleware.py:148:17: E126 continuation line over-indented for hanging indent
tests/test_middleware.py:149:17: E126 continuation line over-indented for hanging indent
tests/test_middleware.py:150:17: E126 continuation line over-indented for hanging indent
tests/test_migrate_nova_auth.py:141:25: E126 continuation line over-indented for hanging indent
tests/test_s3_token_middleware.py:32:13: E126 continuation line over-indented for hanging indent
tests/test_s3_token_middleware.py:35:9: E123 closing bracket does not match indentation of opening bracket's line
tests/test_serializer.py:43:17: E126 continuation line over-indented for hanging indent
tests/test_serializer.py:44:17: E126 continuation line over-indented for hanging indent
tests/test_serializer.py:46:17: E126 continuation line over-indented for hanging indent
tests/test_serializer.py:47:17: E126 continuation line over-indented for hanging indent
tests/test_setup.py:40:25: E128 continuation line under-indented for visual indent
tests/test_setup.py:46:25: E128 continuation line under-indented for visual indent
tests/test_setup.py:52:25: E128 continuation line under-indented for visual indent
tests/test_ssl.py:46:13: E128 continuation line under-indented for visual indent
tests/test_ssl.py:48:13: E128 continuation line under-indented for visual indent
tests/test_ssl.py:66:13: E128 continuation line under-indented for visual indent
tests/test_ssl.py:68:13: E128 continuation line under-indented for visual indent
tests/test_ssl.py:87:13: E128 continuation line under-indented for visual indent
tests/test_ssl.py:89:13: E128 continuation line under-indented for visual indent
tests/test_swift_auth_middleware.py:70:27: E128 continuation line under-indented for visual indent

Derek Higgins (derekh)
Changed in keystone:
assignee: nobody → Derek Higgins (derekh)
Dolph Mathews (dolph)
Changed in keystone:
milestone: none → folsom-3
status: New → Confirmed
Revision history for this message
Rafael Durán Castañeda (rafadurancastaneda) wrote :

It seems after upgrading pep8 checks are much more strict, maybe too much?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/9519

Changed in keystone:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/9519
Committed: http://github.com/openstack/keystone/commit/7cdae1bc02df9a6b79a7ee3e5ebc807bcdd11430
Submitter: Jenkins
Branch: master

commit 7cdae1bc02df9a6b79a7ee3e5ebc807bcdd11430
Author: Derek Higgins <email address hidden>
Date: Mon Jul 9 16:05:59 2012 +0100

    Fixing pep8 errors in tests/*py

    Fixes bug 1022575

    Making change to tests/*py to pass pep8 tests.
    pep8 tests started failing following
    39b20acc933cb0fdf73075ddb9a9d82665b84b23 update pep8 to 1.3.3
    04df79b64e5f2296df03579700535774e158f623 include tests dir in pep8 tests

    Change-Id: I2d7dec0a87f1ae9b5f828d7f321b65bf8c06a421

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in keystone:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: folsom-3 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.