Plank

Draw optional shadow for each dockitem

Bug #1031077 reported by Adrian Widerski
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Plank
Fix Released
Wishlist
Rico Tzschichholz

Bug Description

I think Plank should render shadows behind icons in dock. Almost everything have shadows, so why not Plank? And enabling/disabling this feature in theme file of course.

Tags: icons shadows

Related branches

lp:~docky-core/plank/item-shadows
Robert Dyer (community): Approve
Danielle Foré: Approve
Diff: 510 lines (+227/-9)
8 files modified
data/themes/Default/dock.theme (+2/-0)
lib/DockRenderer.vala (+70/-2)
lib/Drawing/DockSurface.vala (+69/-0)
lib/Drawing/DockTheme.vala (+12/-0)
lib/Items/DockItem.vala (+38/-3)
lib/Items/DockItemProvider.vala (+9/-0)
lib/PositionManager.vala (+18/-4)
lib/libplank.symbols (+9/-0)
lp:plank
Revision history for this message
Robert Dyer (psybers) wrote :

I think the window manager can add shadows to the dock, if it so chooses. Doesn't seem like specific apps should draw their own shadows.

Changed in plank:
status: New → Opinion
Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

WMs cannot draw shadows for composited windows like Plank, so it's up to the client in this case.

Revision history for this message
Rico Tzschichholz (ricotz) wrote :

@robert: I think he isn't talking about the window. As i understand it he requests icon-shaped shadows for every dockitem.

Revision history for this message
Danielle Foré (danrabbit) wrote :

I'd like to second what Rico is asking for. Having shadows cast on the background for the icons (but not the dock itself) would be cool.

Rico Tzschichholz (ricotz)
no longer affects: gala
Revision history for this message
Robert Dyer (psybers) wrote :

Would the original bug submitter please clarify what they meant?

Changed in plank:
status: Opinion → Incomplete
importance: Undecided → Wishlist
Revision history for this message
Adrian Widerski (adrian-widerski) wrote :

My old mockup describes my suggestion: http://dikoo.deviantart.com/gallery/#/d4jnsuf

Rico Tzschichholz (ricotz)
summary: - Feature request: Shadow behind icons
+ Draw optional shadow for each dockitem
Changed in plank:
status: Incomplete → Confirmed
Revision history for this message
Danielle Foré (danrabbit) wrote :

Should the dock mask off the shadow like this?

Revision history for this message
Rico Tzschichholz (ricotz) wrote :

@dan: I have started playing around with it.

Revision history for this message
Danielle Foré (danrabbit) wrote :

Oh very cool. I think you are right (from IRC) that the shadows do seem way too harsh. probably a small radius and low transparency is better. So it's a very subtle effect.

Revision history for this message
Robert Dyer (psybers) wrote :

My only concern is performance. Even though we will cache the results, the blur code is still relatively slow.

Rico Tzschichholz (ricotz)
Changed in plank:
status: Confirmed → Triaged
Revision history for this message
Cassidy James Blaede (cassidyjames) wrote :

Dan, if I may ask, what was your process for making that shadow in Inkscape, and can we emulate it (at least the values) in Plank? :)

Revision history for this message
Cassidy James Blaede (cassidyjames) wrote :

I'm testing this branch and I think the one thing that I really don't like is that the shadow has a horizontal shift (to the right). Every other light source in our OS is straight on with a verticle shift; it feels wrong to have the dock different.

Rico Tzschichholz (ricotz)
Changed in plank:
status: Triaged → In Progress
assignee: nobody → Rico Tzschichholz (ricotz)
Rico Tzschichholz (ricotz)
Changed in plank:
status: In Progress → Fix Committed
Rico Tzschichholz (ricotz)
Changed in plank:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.