QC issue, too many warnings, r11598 trunk

Bug #1034663 reported by David Mathog
This bug report is a duplicate of:  Bug #1550917: compilation warnings 0.91. Edit Remove
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Triaged
Low
Unassigned

Bug Description

When I built r11598 (trunk) on Ubuntu 12.04 today there were 182 warnings emitted. That is far too many. Barring the very rare case where there is just no way to work around a compiler warning, this number would ideally be zero. Yes, most of them are probably harmless, but until proven otherwise, one would have to assume that every one of them is a bug. This is why it is just bad form to have this many in trunk.

The warnings broken down by gcc -W* error are:

       6 deprecated-declarations
       1 format
       8 missing-field-initializers
     12 sign-compare
       6 strict-aliasing
       4 switch
       2 type-limits
     15 uninitialized
   119 unused-but-set-parameter
       9 write-strings

The list is from:

make 2>&1 | tee build_1.log
 grep 'warning:' build_1.log > warnings.txt

I understand that warnings can show up on one platform that were not present on another. But these should have shown up on either Linux or Mac, which is where most of the development occurs.

Revision history for this message
David Mathog (mathog) wrote :
Revision history for this message
su_v (suv-lp) wrote :

Warnings about breaking strict aliasing rules:
Bug #168548 ”inkscape-0.45.1 breaks strict aliasing rules”
Bug #323414 "strict-aliasing rules warnings”

Warnings about deprecated functions in Pango are tracked in
Bug #166276 “pango_ft2_font_get_face is deprecated”
(see also Bug #1016020)

Warnings from poppler include files -> upstream issue (poppler -> Xpdf)
<http://lists.freedesktop.org/archives/poppler/2008-April/003712.html>
(possibly that policy has changed by now)

Warnings from local libgdl:
Migration to use external shared lib is on the roadmap, tracked in
Bug #792115 “Build against external libgdl”

Warnings from local libcroco:
Migration to use external shared lib is on the roadmap, tracked in
Bug # #648246 "Get rid of embedded copy of libcroco”
(Note: earlier reports about libcroco warnings had been closed as 'Won't fix': e.g. bug #169400, bug #169401)

tags: added: build
Revision history for this message
su_v (suv-lp) wrote :

Related complaint about warnings in stable release branch:
Bug # #902913 “Warnings while compiling”

jazzynico (jazzynico)
Changed in inkscape:
importance: Undecided → Low
status: New → Triaged
Revision history for this message
jazzynico (jazzynico) wrote :

Fixed revision 11602:
  - spray-context.cpp:477:17: warning: ‘father’ may be used uninitialized in this function
  - spray-context.cpp:479:17: warning: ‘unionResult’ may be used uninitialized in this function
  - live_effects/lpe-rough-hatches.cpp:417:27: warning: comparison between signed and unsigned integer expressions

Revision history for this message
David Mathog (mathog) wrote :

These are the compiler warnings encountered when rebuilding with the r11737 changes on Ubuntu 12.04. Some of them may
be new. I know the splivarot ones at the bottom are not.

jazzynico (jazzynico)
tags: added: code-design
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.