Mock keyring tests
Bug #1035037 reported by
Ken VanDine
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Online Accounts: signond keyring extension |
Fix Released
|
Medium
|
Alberto Mardegan | ||
| signon-keyring-extension (Ubuntu) |
Fix Released
|
Medium
|
Unassigned | ||
Bug Description
We really need the tests run in the package build, but using the keyring during the build is really problematic. The keyring access should be mocked.
Related branches
lp:~mardy/signon-keyring-extension/mock-keyring
- David King (community): Approve
- jenkins (community): Approve (continuous-integration)
-
Diff: 417 lines (+345/-18)4 files modifiedtests/keyring-test.cpp (+3/-17)
tests/mocked-gnome-keyring.c (+304/-0)
tests/mocked-gnome-keyring.h (+36/-0)
tests/tests.pro (+2/-1)
| summary: |
- Mock out keyring tests + Mock keyring tests |
| Changed in signon-keyring-extension (Ubuntu): | |
| assignee: | nobody → Alberto Mardegan (mardy) |
| importance: | Undecided → Medium |
| milestone: | none → ubuntu-12.10-beta-2 |
| Changed in signon-keyring-extension (Ubuntu): | |
| status: | New → In Progress |
Revision history for this message
| Alberto Mardegan (mardy) wrote | #1 |
| Changed in signon-keyring-extension (Ubuntu): | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Alberto Mardegan (mardy) wrote | #2 |
| Changed in signon-keyring-extension (Ubuntu): | |
| assignee: | Alberto Mardegan (mardy) → nobody |
| Changed in online-accounts-keyring-extension: | |
| status: | New → Fix Released |
| assignee: | nobody → Alberto Mardegan (mardy) |
| importance: | Undecided → Medium |
| milestone: | none → 0.4 |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #3 |
| Changed in signon-keyring-extension (Ubuntu): | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Hi Ken, fix is committed, package is tagged (0.4). When you feel like integrating it, you are welcome :-)