Ubuntu
om package

Script 'launchomsynth' brings up two instances of om_gtk

Bug #103507 reported by Carlo Capocasa on 2007-04-05

Affects		Status	Importance	Assigned to	Milestone
	om (Ubuntu)	Fix Released	Undecided	Dan O'Huiginn

Bug Description

Binary package hint: om

The script 'launchomsynth' is there to check for presence of the Om backend, launch if needed, then bring up the user interface. For some reason, the entire contents of the script (including bang line) are present twice in the script, which has the effect of bringing up two instances of the Om user interface when the script is launched through selecting Om in the Ubuntu menu.

Related branches

lp:ubuntu/feisty/om

Dan O'Huiginn (daniel-ohuiginn) on 2007-04-06

Changed in om:
assignee:	nobody → daniel-ohuiginn
status:	Unconfirmed → In Progress

Revision history for this message

Dan O'Huiginn (daniel-ohuiginn) wrote on 2007-04-06:

remove duplication of code Edit (8.9 KiB, text/plain)

Here's a debdiff; I've also moved that script from #!/bin/sh to #!/bin/bash, since it seemed to contain some bashisms.

Revision history for this message

Luke Yelavich (themuso) wrote on 2007-04-10:

That script would be better fixed by removing the bashisms, of which there is only one, and its easy to change.

Simply remove the word function from the line:
function is_om_running() {

So it should be:
is_om_running() {

Could you also update the maintainer field in debian/control as required by the Debian Maintainer Field spec please?

Otherwise, looks good.

Revision history for this message

Dan O'Huiginn (daniel-ohuiginn) wrote on 2007-04-10:

Thanks for your advice, Luke

I'll remove the bashism.

Leaving the maintainer field was deliberate. I asked on #ubuntu-motu about having dana(at)ubuntustudio.com as the maintainer. Most people seemed to think it was acceptable, provided that the email address contains ubuntu and is an accepted ubuntu project. It doesn't matter much in any case, so I'll make the change.

Revision history for this message

Dan O'Huiginn (daniel-ohuiginn) wrote on 2007-04-10:

changed as in Luke's comment Edit (9.4 KiB, text/plain)

Revision history for this message

Luke Yelavich (themuso) wrote on 2007-04-11:

Please mark as fix released once the package has successfully built.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Wed, 11 Apr 2007 00:49:42 +0200
Source: om
Binary: om
Architecture: source
Version: 0.2.0-2ubuntu2
Distribution: feisty
Urgency: low
Maintainer: Ubuntu MOTU Developers <email address hidden>
Changed-By: Dan O'Huiginn <email address hidden>
Description:
om - Realtime modular synthesizer using LADSPA or DSSI plugins
Launchpad-Bugs-Fixed: 103507
Changes:
om (0.2.0-2ubuntu2) feisty; urgency=low
.
   * Fix 'launchomsynth':
     - remove repeated code (LP: #103507)
     - fix a bashism
   * Set maintainer to MOTU
Files:
3a1aff3844dad7a9d52144b06a674291 779 sound optional om_0.2.0-2ubuntu2.dsc
57e0f2606d07a7d91ca764b918a07ad4 25918 sound optional om_0.2.0-2ubuntu2.diff.gz
Original-Maintainer: Dana Olson <email address hidden>

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFGHCOXjVefwtBjIM4RAsfqAJ9SMNWXZ56zsbEzzlJDtvPMqQgpVACgk4k8
3JY3J55ZrWA8bQhYxyui8gc=
=VyC9
-----END PGP SIGNATURE-----