InstanceNotFound, VolumeNotFound, and SnapshotNotFound not raised correctly

Bug #1035375 reported by Vish Ishaya
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Vish Ishaya

Bug Description

The following traceback is printed:

nova.exception: ERROR: Exception in string format operation
2012-08-10 08:43:24 TRACE nova.exception Traceback (most recent call last):
2012-08-10 08:43:24 TRACE nova.exception File "/Users/vishvananda/os/nova/nova/exception.py", line 147, in __init__
2012-08-10 08:43:24 TRACE nova.exception message = self.message % kwargs
2012-08-10 08:43:24 TRACE nova.exception KeyError: 'snapshot_id'
2012-08-10 08:43:24 TRACE nova.exception

Changed in cinder:
assignee: nobody → Vish Ishaya (vishvananda)
Changed in nova:
assignee: nobody → Vish Ishaya (vishvananda)
Changed in cinder:
status: New → In Progress
Changed in nova:
status: New → In Progress
Changed in cinder:
importance: Undecided → Medium
Changed in nova:
importance: Undecided → Medium
no longer affects: cinder
summary: - VolumeNotFound and SnapshotNotFound not raised correctly
+ InstanceNotFound, VolumeNotFound, and SnapshotNotFound not raised
+ correctly
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/11156

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/11156
Committed: http://github.com/openstack/nova/commit/f546f62397979312dd891509c31feadf149b8c59
Submitter: Jenkins
Branch: master

commit f546f62397979312dd891509c31feadf149b8c59
Author: Vishvananda Ishaya <email address hidden>
Date: Fri Aug 10 09:25:10 2012 -0700

    Make sure ec2 mapping raises proper exceptions

    The get commands in the db layer were constructing InstanceNotFound,
    VolumeNotFound, and SnapshotNotFound with imporoper kwargs. This
    fixes them to raise properly and adds a test to verify that the
    exception formatting succeeded.

    Fixes bug 1035375

    Change-Id: I05a5bb57c047ca2b2f086c70ad12a640f51b2d3a

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → folsom-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: folsom-3 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.