glanceclient limits not working as intended

Bug #1037233 reported by Brian Lamar
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance Client
Fix Released
Critical
Brian Lamar

Bug Description

Currently it looks like glanceclient's pagination code has a small bug which causes it to return at minimum the page_size instead of the limit. For example

client.images.list(limit=1)

...returns more than 1 image.

This is only a problem for small limits.

Brian Lamar (blamar)
Changed in glance:
status: New → In Progress
assignee: nobody → Brian Lamar (blamar)
Brian Waldon (bcwaldon)
description: updated
Changed in glance:
importance: Undecided → Critical
affects: glance → python-glanceclient
Revision history for this message
Brian Waldon (bcwaldon) wrote :

Released as v0.4.2

Changed in python-glanceclient:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-glanceclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/11426

Changed in python-glanceclient:
status: Fix Committed → In Progress
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-glanceclient (master)

Reviewed: https://review.openstack.org/11426
Committed: http://github.com/openstack/python-glanceclient/commit/d64876424e87b3a7f76a9bf4d29fdacbc5ad4bc4
Submitter: Jenkins
Branch: master

commit d64876424e87b3a7f76a9bf4d29fdacbc5ad4bc4
Author: Brian Lamar <email address hidden>
Date: Wed Aug 15 14:39:39 2012 -0400

    Ensure v1 'limit' query parameter works correctly.

    The tests were present but were not asserting list results.

    page_size was overriding the absolute limit so limits were
    not working if they were less than the page_size.

    Fixes bug 1037233

    Change-Id: If102824212e3846bc65d3f7928cf7aa2e48aaa63

Revision history for this message
Brian Waldon (bcwaldon) wrote :

Released in v0.4.2

Changed in python-glanceclient:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.