nova admin based on hard-coded 'admin' role

Bug #1037786 reported by Vish Ishaya
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Critical
Qiu Yu

Bug Description

There are many places in the code (especially the database layer) that rely on checking context.is_admin. Unfortunately is_admin is still set from a hard coded role 'admin'. This should be changed to set it based on a policy check.

Changed in nova:
status: New → Triaged
importance: Undecided → Critical
milestone: none → folsom-rc1
Qiu Yu (unicell)
Changed in nova:
assignee: nobody → unicell (unicell)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/11606

Changed in nova:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/11606
Committed: http://github.com/openstack/nova/commit/c6be78deb6a3a7cbf092efdfb54f561ce689605f
Submitter: Jenkins
Branch: master

commit c6be78deb6a3a7cbf092efdfb54f561ce689605f
Author: unicell <email address hidden>
Date: Sat Aug 18 14:23:01 2012 +0800

    Remove hard-coded 'admin' role checking and use policy instead

    bug 1037786

    This change removed hard-coded 'admin' role checking, and use policy check to
    decide is_admin at the time of context construction. And also set
    default admin role to 'admin', in policy template, to keep backward
    compatibility.

    Change-Id: I56b45bfdfba1b8e1391bde7fec3d4cf26c66324c

Changed in nova:
status: In Progress → Fix Committed
Qiu Yu (unicell)
Changed in nova:
status: Fix Committed → Fix Released
Changed in nova:
status: Fix Released → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: folsom-rc1 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.