OpenStack Compute (nova)

extra_specs matching failure with trailing <or> operator

Bug #1038979 reported by Jinwoo "Joseph" Suh
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Jinwoo "Joseph" Suh
OpenStack Compute (nova) 2012.2 "folsom"

Bug Description

https://review.openstack.org/#/c/11460/ refactored extra_spec match code. It introduced a bug:

- For <or> operation, if no required word follows an <or>, it crashes. For example, if "<or> aa <or>" is given as extra_specs, it makes it crash since the code tries to pop a word after the second <or>.

See original description
Jinwoo "Joseph" Suh (jsuh)
Changed in nova:
assignee: nobody → Jinwoo "Joseph" Suh (jsuh)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/11643

Changed in nova:
status: New → In Progress
Jinwoo "Joseph" Suh (jsuh)
description: updated
Jinwoo "Joseph" Suh (jsuh)
description: updated
Mark McLoughlin (markmc)
Changed in nova:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/11643
Committed: http://github.com/openstack/nova/commit/ada550098ac874cdd3ca7c6637421edf6c7f7163
Submitter: Jenkins
Branch: master

commit ada550098ac874cdd3ca7c6637421edf6c7f7163
Author: Jinwoo 'Joseph' Suh <email address hidden>
Date: Mon Aug 20 07:43:21 2012 -0400

    Debugged extra_specs_ops.py

    The current extra_specs_ops.py under nova/scheduler/filters has a bug:
    it crahses if <or> is not followed by a word. For example, if
    "<or> gpu <or>" is given in extra_specs, current code tries to pop a
    word after the second <or> that causes a crash. This patch lets it
    ignore the "<or>" keyword if no word follows the second "<or>" keyword.

    Debugged bug 1038979

    Change-Id: I80a6eafd7ee57a2f3ccbf2fb869655ab84e92cf2

Changed in nova:
status: In Progress → Fix Committed
Mark McLoughlin (markmc)
summary: - extra_specs with no keyword not ignored
+ extra_specs matching failure with trailing <or> operator
Thierry Carrez (ttx)
Changed in nova:
milestone: none → folsom-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: folsom-rc1 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.