OpenStack Compute (nova)

create_db_entry_for_new_instance call signature mismatch

Bug #1042302 reported by Yun Mao
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Vish Ishaya
OpenStack Compute (nova) 2012.2 "folsom"

Bug Description

In the compute api, it is defined as

def create_db_entry_for_new_instance(self, context, instance_type, image,
            base_options, security_group, block_device_mapping)

However, in the scheduler driver, it calls as
        instance = self.compute_api.create_db_entry_for_new_instance(
                context, instance_type, image, base_options,
                security_group, block_device_mapping, reservations)

That is there is one extra parameter reservations. So it's guaranteed to fail.

Vish Ishaya (vishvananda)
Changed in nova:
importance: Undecided → High
status: New → In Progress
assignee: nobody → Vish Ishaya (vishvananda)
milestone: none → folsom-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/12013

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/12013
Committed: http://github.com/openstack/nova/commit/269bad54b6a94b01b2835707c75038d560f59cb8
Submitter: Jenkins
Branch: master

commit 269bad54b6a94b01b2835707c75038d560f59cb8
Author: Vishvananda Ishaya <email address hidden>
Date: Mon Aug 27 11:14:37 2012 -0700

    Fixes backwards compatible rpc schedule_run

    Commit 8718f8e47d7d0504724495538eb320be3e209180 changed the
    schedule_run_instance call to create all of the db records on the
    compute host, but the old code path was left in for backwards
    compatibility. Unfortunately an extra reservations parameter was
    left in causing the backwards compatibility to be broken.

    This patch takes out the reservations parameter and commits the
    reservation in the backwards compatible call.

    Fixes bug 1042302

    Change-Id: I1e710d1e9a992f59a18eeedcd7d71726ff96c485

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: folsom-rc1 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.