BatchAction: incongruence between documentation and code

Bug #1044424 reported by Rosario Di Somma
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Undecided
Rosario Di Somma

Bug Description

The BatchAction class in the tables package define the success_url variable in the docs but use completion_url in the code.

Definition in the docs
https://github.com/openstack/horizon/blob/master/horizon/tables/actions.py#L425

Usage in the code
https://github.com/openstack/horizon/blob/master/horizon/tables/actions.py#L430
https://github.com/openstack/horizon/blob/master/horizon/tables/actions.py#L488

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/12283

Changed in horizon:
assignee: nobody → Rosario Di Somma (mr-rods)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/12283
Committed: http://github.com/openstack/horizon/commit/caf8eaffb9b078f06579a02211052ae591ba92ee
Submitter: Jenkins
Branch: master

commit caf8eaffb9b078f06579a02211052ae591ba92ee
Author: Rosario Di Somma <email address hidden>
Date: Fri Aug 31 17:14:42 2012 -0400

    Fix BatchAction class incongruence between documentation and code
    Fixes launchpad bug #1044424

    The BatchAction class in the tables package define the success_url variable in the docs but use completion_url in the code.

    Change-Id: Ia93eeee4eccb4250d4b0984f38585175de738907

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
milestone: none → folsom-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: folsom-rc1 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.