Some language strings are misspelled

https://reviews.mahara.org/1613

Reviewed: https://reviews.mahara.org/1613
Committed: http://gitorious.org/mahara/mahara/commit/89fadbba32c8946d54af26eb51fe8e8812df0b7a
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 89fadbba32c8946d54af26eb51fe8e8812df0b7a
Author: Kristina D.C. Hoeppner <email address hidden>
Date: Sun Sep 2 13:33:50 2012 +1200

    Correct 2 minor lang strings (Bug #1044822)

    no string ID changes necessary as only minor
    fixes in English that don't affect translations

    Change-Id: I43c292bf847b72b5d887364fcd1715ba7162b00b
    Signed-off-by: Kristina D.C. Hoeppner <email address hidden>

Reviewed: https://reviews.mahara.org/1617
Committed: http://gitorious.org/mahara/mahara/commit/a9179518af30f48ff4a29e017a85fddfd727a188
Submitter: Hugh Davenport (<email address hidden>)
Branch: 1.6_STABLE

commit a9179518af30f48ff4a29e017a85fddfd727a188
Author: Kristina D.C. Hoeppner <email address hidden>
Date: Sun Sep 2 13:33:50 2012 +1200

    Correct 2 minor lang strings (Bug #1044822)

    no string ID changes necessary as only minor
    fixes in English that don't affect translations

    Change-Id: I43c292bf847b72b5d887364fcd1715ba7162b00b
    Signed-off-by: Kristina D.C. Hoeppner <email address hidden>

More...
3. 'cantfindforum' should be 'Couldn't find forum with id %s'

Son,

Please don't update the original note when you find new strings to update. That is confusing because I can't easily see which ones have already been fixed, and I need to go through the entire list again unless I have kept the email in which Launchpad marked the changes.

The ongoing bug number for lang strings that don't require retranslation is #892959.

Thanks
Kristina

It would also help, if you already post the string, to have its location as well. Your #2 for example exists twice due to being used in different contexts. One was correct, but not the other one...

9. in help file 'auth/xmlrpc/lang/en.utf8/help/forms/auth_config.theyautocreateusers.html', the heading should be '<h3>They auto-create users</h3>'
10. in help file 'auth/xmlrpc/lang/en.utf8/help/forms/auth_config.weautocreateusers.html', the heading should be '<h3>We auto-create users</h3>'

Hi Son,

Can you please fix 4 and 5?

What is wrong with 7 in your opinion? And why should 8 not contain usersuniquebysusername? That is the important setting here.

11. help file 'interaction/forum/lang/en.utf8/help/forms/subscribe_forum.submit.html'. 'notificatons' -> 'notifications '

12. help file 'interaction/forum/lang/en.utf8/help/forms/subscribe_topic.submit.html'. 'notificatons' -> 'notifications'

11 and 12 fixed. I would leave 9 and 10 as they are, but I fixed something else in the string of 10.

Hi Kristina;

About #7, IMO I would remove the word 'YOUR' as it made me confused.
8. I would replace the string 'usersuniquebyusername' by '$cfg->usersuniquebyusername in the config.php'

About #5, I would leave it until the problem about user's time zone and format are solved.

Hi Son,

Thanks for the explanations for 7 and 8. Fixed #7 but will leave #8 for the time being until all minor lang changes are made as that would require a string change since it's not a minor fix.

About #4, I would remove these strings 'replyforumpostnotificationsubjectline' and 'newforumpostnotificationsubjectline' and replace them by 'Re:' = 'Re: '
I need also change the code of using these strings

I will fix #4

Here is my fix for #4: https://reviews.mahara.org/#/c/1661/

Reviewed: https://reviews.mahara.org/1661
Committed: http://gitorious.org/mahara/mahara/commit/b18f75e4ba982c4c1d0f399208b25840c96bcbae
Submitter: Hugh Davenport (<email address hidden>)
Branch: master

commit b18f75e4ba982c4c1d0f399208b25840c96bcbae
Author: Son Nguyen <email address hidden>
Date: Fri Sep 14 09:36:46 2012 +1200

    Fix 'newforumpostnotificationsubjectline' and
    'replyforumpostnotificationsubjectline' strings

    (Bug #1044822)

    Change-Id: I5eb39dcc7d84414e77af704623cacb218ce71b01
    Signed-off-by: Son Nguyen <email address hidden>

13. In 'lang/en.utf8/admin.php registrationfailedtrylater'. 'Registation' should be 'Registration '

14. In 'lang/en.utf8/admin.php registrationsuccessfulthanksforregistering', 'Registation' should be 'Registration'

Reviewed: https://reviews.mahara.org/1672
Committed: http://gitorious.org/mahara/mahara/commit/9e93285c13d0a895fff66a9a9c9caa2dc8716bf6
Submitter: Hugh Davenport (<email address hidden>)
Branch: 1.6_STABLE

commit 9e93285c13d0a895fff66a9a9c9caa2dc8716bf6
Author: Son Nguyen <email address hidden>
Date: Fri Sep 14 09:36:46 2012 +1200

    Fix 'newforumpostnotificationsubjectline' and
    'replyforumpostnotificationsubjectline' strings

    (Bug #1044822)

    Change-Id: I5eb39dcc7d84414e77af704623cacb218ce71b01
    Signed-off-by: Son Nguyen <email address hidden>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 status fixreleased
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iJwEAQECAAYFAlCbHO8ACgkQuMoJ2LQ3zxH8TAP/YN4BiCJZsn5a899/0UzV31Qg
lM8LXAwZWa6zFv6t0BQUHCqe6eFK9wPp51qgCWWXjUZ3vvvVcsyeWp6626aBFKSU
pCQXI9E7huPw802nJQ9WcZXRBUmgw87ww72Tx4mybnu7SPSrkZgXdnPGSMwDs89N
oWvTpl7Xuac48e6p0lU=
=ouU+
-----END PGP SIGNATURE-----