Mahara

Errors when adding new institution members

Bug #1046114 reported by Son Nguyen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Nitish Bezzala
Mahara 1.8.0
1.6
Fix Released
Medium
Son Nguyen
Mahara 1.6.8
1.7
Fix Released
Medium
Son Nguyen
Mahara 1.7.4

Bug Description

Versions: all
Platforms: all
Browsers: all

Assumptions
 - User 'u01' is the admin of institution 'A' with the option 'Confirm registration' is on
 - The logged in user 'u02' is not the member of institution 'A'.

Actions
 1. The logged in User 'u02' sent a requested membership of institution 'A'.
 2. User 'u01' added user 'u02' as a new member of institution 'A'.
 3. User 'u02' without re-login access to the 'Institution membership' page and send a request AGAIN.
 4. User 'u01' AGAIN added user 'u02' to institution 'A'.

Expected results
 - The system should refuse user 'u01' to add user u02 AGAIN, then display a message about the reason.

Actual results
 - Errors raised
(see the attached image)

Revision history for this message
Son Nguyen (ngson2000) wrote :
Melissa Draper (melissa)
Changed in mahara:
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
Nitish Bezzala (nbezzala) wrote :

When a user is added to a new institution, why is it required that they log out and log in to access it?

Revision history for this message
Aaron Wells (u-aaronw) wrote :

Probably because we're drawing their institution memberships from the database when they log in, and then storing them in the user's session and not checking for updates on subsequent page loads (since it's quite rare for a user's institution memberships to change).

We could force the user to log out and back in again, though, by calling the function remove_user_sessions($userid). For instance, this is what we call in admin/users/edit.php, when an admin changes a user's account settings, to force them to log out and back in again.

Cheers,
Aaron

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

https://reviews.mahara.org/#/c/2614/

Changed in mahara:
assignee: nobody → Nitish Bezzala (nbezzala)
status: Triaged → In Progress
milestone: none → 1.8.0
Aaron Wells (u-aaronw)
Changed in mahara:
milestone: 1.8.0 → 1.8.1
Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
milestone: 1.8.1 → 1.8.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/2614
Committed: http://gitorious.org/mahara/mahara/commit/b23694289a5a582ae8d94a299fdaa5e5f1fa468f
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit b23694289a5a582ae8d94a299fdaa5e5f1fa468f
Author: Nitish Bezzala <email address hidden>
Date: Wed Oct 16 05:39:26 2013 -0500

Errors when adding new institution members (bug 1046114)

Once the members have been added and the change has been commited
to the database, logout each user who has been added.

Change-Id: I732c7fcbb5ea5913c5e3def8a7a3950c5e83e554
Signed-off-by: Nitish Bezzala <email address hidden>

Son Nguyen (ngson2000)
Changed in mahara:
status: In Progress → Fix Committed
Aaron Wells (u-aaronw)
Changed in mahara:
status: Fix Committed → Fix Released
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/2657
Committed: http://gitorious.org/mahara/mahara/commit/9a7bf75d517ff1524730d7de5d7d66120be907bc
Submitter: Son Nguyen (<email address hidden>)
Branch: 1.6_STABLE

commit 9a7bf75d517ff1524730d7de5d7d66120be907bc
Author: Nitish Bezzala <email address hidden>
Date: Wed Oct 16 05:39:26 2013 -0500

Errors when adding new institution members (bug 1046114)

Once the members have been added and the change has been commited
to the database, logout each user who has been added.

Change-Id: I732c7fcbb5ea5913c5e3def8a7a3950c5e83e554
Signed-off-by: Nitish Bezzala <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/2658
Committed: http://gitorious.org/mahara/mahara/commit/f3ffc413dfd6f0370ddb94926c8a762acb4e4238
Submitter: Son Nguyen (<email address hidden>)
Branch: 1.7_STABLE

commit f3ffc413dfd6f0370ddb94926c8a762acb4e4238
Author: Nitish Bezzala <email address hidden>
Date: Wed Oct 16 05:39:26 2013 -0500

Errors when adding new institution members (bug 1046114)

Once the members have been added and the change has been commited
to the database, logout each user who has been added.

Change-Id: I732c7fcbb5ea5913c5e3def8a7a3950c5e83e554
Signed-off-by: Nitish Bezzala <email address hidden>

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.