patch for bug #1008866 is reverted

Bug #1047841 reported by Akira Yoshiyama
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Critical
Rongze Zhu

Bug Description

Commit 2f5360753308eb8b10581fc3c026c1b66f42ebdc (Adds new volume API extensions) reverted a part of commit 99456bd690445443ae05c0d4fe1ec43ba6090f6f (Send 'create volume from snapshot' to the proper host), so bug #1008866 is reproduced.

Nova doesn't have this problem.

from 99456bd690445443ae05c0d4fe1ec43ba6090f6f :
---
diff --git a/cinder/volume/api.py b/cinder/volume/api.py
index 614b39d..9784d87 100644
--- a/cinder/volume/api.py
+++ b/cinder/volume/api.py
@@ -113,14 +119,36 @@ class API(base.Base):
             }

         volume = self.db.volume_create(context, options)
- rpc.cast(context,
- FLAGS.scheduler_topic,
- {"method": "create_volume",
- "args": {"topic": FLAGS.volume_topic,
- "volume_id": volume['id'],
- "snapshot_id": snapshot_id}})
+ self._cast_create_volume(context, volume['id'], snapshot_id)
         return volume
---
from 2f5360753308eb8b10581fc3c026c1b66f42ebdc:
---
diff --git a/cinder/volume/api.py b/cinder/volume/api.py
index ffe3dc0..003b3cf 100644
--- a/cinder/volume/api.py
+++ b/cinder/volume/api.py

@@ -116,9 +132,14 @@ class API(base.Base):
             'volume_type_id': volume_type_id,
             'metadata': metadata,
             }
-
         volume = self.db.volume_create(context, options)
- self._cast_create_volume(context, volume['id'], snapshot_id)
+ rpc.cast(context,
+ FLAGS.scheduler_topic,
+ {"method": "create_volume",
+ "args": {"topic": FLAGS.volume_topic,
+ "volume_id": volume['id'],
+ "snapshot_id": volume['snapshot_id'],
+ "image_id": image_id}})
         return volume
---

Akira Yoshiyama (yosshy)
description: updated
description: updated
description: updated
Changed in cinder:
status: New → Triaged
importance: Undecided → Critical
milestone: none → folsom-rc1
Rongze Zhu (zrzhit)
Changed in cinder:
assignee: nobody → Rongze Zhu (zrzhit)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/12675

Changed in cinder:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/12675
Committed: http://github.com/openstack/cinder/commit/3eaf43a9f5a26a51a89347cffe39bfae2b12c2d6
Submitter: Jenkins
Branch: master

commit 3eaf43a9f5a26a51a89347cffe39bfae2b12c2d6
Author: Rongze Zhu <email address hidden>
Date: Sun Sep 9 15:35:26 2012 +0800

    Prevent from bug #1008866 is reverted

    Fixes bug #1047841.

    Commit 2f5360753308eb8b10581fc3c026c1b66f42ebdc (Adds new volume API
    extensions) reverted a part of commit
    99456bd690445443ae05c0d4fe1ec43ba6090f6f (Send 'create volume from
    snapshot' to the proper host), so bug #1008866 is reproduced. I make
    API.create_volume to call _cast_create_volume in cinder/volume/api.py,
    it Prevent from bug #1008866 is reverted.

    Change-Id: I1bf0b7c5fc47da756bce95128f8fd770d14399b0

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: folsom-rc1 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.