Cinder

nova.tests.test_iscsi:TgtAdmTestCase leaves a file

Bug #1050086 reported by Joe Gordon on 2012-09-12

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Cinder	Fix Released	Undecided	John Griffith	Cinder 2012.2 "folsom"
	OpenStack Compute (nova)	Fix Released	Undecided	John Griffith	OpenStack Compute (nova) 2012.2 "folsom"

Bug Description

When running './run_tests.sh -x nova.tests.test_iscsi:TgtAdmTestCase' a file is left after the test completes.

Same result for './run_tests.sh -x cinder.tests.test_iscsi'

$ git status
# On branch master
nothing to commit (working directory clean)
$ ./run_tests.sh -x nova.tests.test_iscsi:TgtAdmTestCase

TgtAdmTestCase
test_target_admin OK 0.02

----------------------------------------------------------------------
Ran 1 test in 1.052s

OK
$ git status
# On branch master
# Untracked files:
# (use "git add <file>..." to include in what will be committed)
#
# nova/tests/blaa
nothing added to commit but untracked files present (use "git add" to track)

See original description

John Griffith (john-griffith) on 2012-09-12

Changed in cinder:
status:	New → Triaged

Joe Gordon (jogo) on 2012-09-12

description:

updated

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2012-09-12: Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/12910

Changed in cinder:
assignee:	nobody → John Griffith (john-griffith)
status:	Triaged → In Progress
Changed in nova:
assignee:	nobody → John Griffith (john-griffith)
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2012-09-12: Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/12911

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2012-09-13: Fix merged to cinder (master)

Reviewed: https://review.openstack.org/12910
Committed: http://github.com/openstack/cinder/commit/96f72f2cfd0afa6e60399dadd30bb83b0ab8ee0e
Submitter: Jenkins
Branch: master

commit 96f72f2cfd0afa6e60399dadd30bb83b0ab8ee0e
Author: John Griffith <email address hidden>
Date: Wed Sep 12 16:52:02 2012 -0600

Use tmpdir and avoid leaving test files behind

We were just creating a file for testing iscsi persist files and
weren't cleaning up after the test.

Change this to use a tmpdir and make sure we leave no tracks.

Fixes bug #1050086

Change-Id: I9b9a2400a172d52987d76f3132793cb042fd201c

Changed in cinder:
status:	In Progress → Fix Committed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2012-09-14: Fix merged to nova (master)

Reviewed: https://review.openstack.org/12911
Committed: http://github.com/openstack/nova/commit/c72935f17272d117930a4c4c76426f26d786e421
Submitter: Jenkins
Branch: master

commit c72935f17272d117930a4c4c76426f26d786e421
Author: John Griffith <email address hidden>
Date: Wed Sep 12 17:04:17 2012 -0600

Use tmpdir and avoid leaving test files behind

We were just creating a file for testing iscsi persist files and
weren't cleaning up after the test.

Change this to use a tmpdir and make sure we leave no tracks.

Fixes bug #1050086

Change-Id: I714177d7789da8b628ab63c163a2c3f1698dd940

Changed in nova:
status:	In Progress → Fix Committed

Thierry Carrez (ttx) on 2012-09-18

Changed in cinder:
milestone:	none → folsom-rc1
status:	Fix Committed → Fix Released

Thierry Carrez (ttx) on 2012-09-19

Changed in nova:
milestone:	none → folsom-rc1
status:	Fix Committed → Fix Released

Thierry Carrez (ttx) on 2012-09-27

Changed in cinder:
milestone:	folsom-rc1 → 2012.2

Thierry Carrez (ttx) on 2012-09-27

Changed in nova:
milestone:	folsom-rc1 → 2012.2

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.