Mahara

Invalid short tag on site logo link in header

Bug #1052062 reported by Rich Trott
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Son Nguyen
Mahara 1.6.0

Bug Description

Mahara 1.6 generates this code out of `htdocs/theme/raw/templates/header/head.tpl` and/or `htdocs/theme/default/templates/header/head.tpl`:

    <link rel="image_src" href="{$sitelogo}" />

Since the DOCTYPE specified HTML 4.01, this is technically invalid. It should either not use the short tag or (my preference) change the doctype to HTML5 (or do both).

See original description
Tags: bite-sized
Rich Trott (richard-trott)
description: updated
Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

This is related to the new feature bug #900529 when that logo was introduced.

Changed in mahara:
assignee: nobody → Son Nguyen (ngson2000)
Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
milestone: none → 1.6.0
Revision history for this message
Son Nguyen (ngson2000) wrote :

According to W3C

In HTML the <link> tag has no end tag.

In XHTML the <link> tag must be properly closed.

In Mahara code, there are many places using the <link> tag with end tag: />

Should we fix all occurences?

Changed in mahara:
status: New → In Progress
Revision history for this message
Son Nguyen (ngson2000) wrote :

Actually, there are 6 places in Mahara code. I will fix them all in my patch.

Revision history for this message
Son Nguyen (ngson2000) wrote :

https://reviews.mahara.org/#/c/1679/

Hugh Davenport (hugh-davenport)
Changed in mahara:
importance: Undecided → Medium
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/1679
Committed: http://gitorious.org/mahara/mahara/commit/e629a64cd82ff2860b0db6df31043f0d9830db8e
Submitter: Melissa Draper (<email address hidden>)
Branch: master

commit e629a64cd82ff2860b0db6df31043f0d9830db8e
Author: Son Nguyen <email address hidden>
Date: Tue Sep 18 14:26:45 2012 +1200

    Fix: the <link> tag in HTML should have no end tag (bug #1052062)

    Change-Id: I58aa9833025de37e1970c16b67f4c3bc14cf17d4
    Signed-off-by: Son Nguyen <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/1723
Committed: http://gitorious.org/mahara/mahara/commit/60e78d1904a2206f5a4923e5e3829dbd8321ca2e
Submitter: Hugh Davenport (<email address hidden>)
Branch: 1.6_STABLE

commit 60e78d1904a2206f5a4923e5e3829dbd8321ca2e
Author: Son Nguyen <email address hidden>
Date: Tue Sep 18 14:26:45 2012 +1200

    Fix: the <link> tag in HTML should have no end tag (bug #1052062)

    Change-Id: I58aa9833025de37e1970c16b67f4c3bc14cf17d4
    Signed-off-by: Son Nguyen <email address hidden>

Hugh Davenport (hugh-davenport)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Hugh Davenport (hugh-davenport) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 status fixreleased
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iJwEAQECAAYFAlCbHO8ACgkQuMoJ2LQ3zxH8TAP/YN4BiCJZsn5a899/0UzV31Qg
lM8LXAwZWa6zFv6t0BQUHCqe6eFK9wPp51qgCWWXjUZ3vvvVcsyeWp6626aBFKSU
pCQXI9E7huPw802nJQ9WcZXRBUmgw87ww72Tx4mybnu7SPSrkZgXdnPGSMwDs89N
oWvTpl7Xuac48e6p0lU=
=ouU+
-----END PGP SIGNATURE-----

Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.