menu closes only after a page refresh on mobile

this is on 16rc1

What kind of device did you have, Dirk? I don't notice it on my phone or 7" tablet all the time when I switch the orientation. What I did notice though today is that I can't close the menu anymore when it shows up unfolded directly. It works find when it was folded initially. Do you see that behavior as well?

HTC Desire running Gingerbread.
I can confirm what you describe. Refreshing the page will always close the
menu and it works properly then. Clicking other menu items, it will always
be open at first.
Also noticed that it switches back to the regular, non-mobile menu when
tilted horizontally. On larger screens such as iPad it does not use the
mobile menu at all irregardless of orientation. Same is true for 10 inch
Android Iconia Tablet. This is what threw me off in my earlier bug reports
as it appears to not use adaptive theme in larger screens, at least for the
menu, which I find confusing.

On Mon, Sep 17, 2012 at 3:33 PM, Kristina Hoeppner <
<email address hidden>> wrote:

> What kind of device did you have, Dirk? I don't notice it on my phone or
> 7" tablet all the time when I switch the orientation. What I did
> notice though today is that I can't close the menu anymore when it shows
> up unfolded directly. It works find when it was folded initially. Do you
> see that behavior as well?
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1052071
>
> Title:
> menu closes only after a page refresh on mobile
>
> Status in Mahara ePortfolio:
> New
>
> Bug description:
> When holding the device vertically (width < height) the menu stays
> open all the time unless the page is refreshed.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mahara/+bug/1052071/+subscriptions
>

Evonne said this might be a problem with Javascript not recalculating after switching the orientation.

Hugh (Motorola MB525 with Cyeogenmod based on Android 2.3.7) doesn't have that issue.

Will keep this for 1.6 for now dependent on how many other devices it affects

Actually, I can reproduce the menu not being clickable with just chrome and some resizing

Start at width < 490 px where menu is rolled up, increase to >= 490 px and < 600 px, menu is now rolled down, and clicking doesn't do anything. refresh works.

When refreshed within the 490 - 600 px range, if you increase >= 600 px, it doesn't swap back to full site.

Can also see it when you start >= 600px, then decrease to 490-600px range, menu is rolled down and unclickable

After applying this patch https://reviews.mahara.org/1682 you wrote for this bug discussion https://bugs.launchpad.net/mahara/+bug/1052060 ( unable to access administration menu on mobile) I don't experience the behavior reported above. Mind you I used Opera for a while which was working better for me with respect to this bug and now I switched back and its all good.

Hi Dirk,

That is interesting. It could be the browser had some effect in it. I have also made a patch for this bug (which I could reproduce by just re-sizing my desktop browser. Would you mind going back to the old browser and testing with and without this patch?

https://reviews.mahara.org/1716

Cheers,

Hugh

Hi Dirk,

I have tried reproducing it when I have my other patch on, and still run into the same issues (though I am using a desktop client and re-sizing).

Cheers,

Hugh

Reviewed: https://reviews.mahara.org/1716
Committed: http://gitorious.org/mahara/mahara/commit/44e8326b219deba913bfd3e25dedfcb8da3a258c
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 44e8326b219deba913bfd3e25dedfcb8da3a258c
Author: Hugh Davenport <email address hidden>
Date: Mon Sep 24 09:32:35 2012 +1200

    Fix width of responsive menu (Bug #1052071)

    The width was created as the combined width of all the
    submenu's, which have different widths dependant on size
    of screen.

    In CSS, there is a cutover at 600px (a media query), so
    this JS code to take elements off etc, should have the
    same cutover width.

    Change-Id: Ibe71db1bee73e70960740ebcb7a1bb1a3179e436
    Signed-off-by: Hugh Davenport <email address hidden>

Reviewed: https://reviews.mahara.org/1719
Committed: http://gitorious.org/mahara/mahara/commit/3e5f6b64271d8866266a3a764fd6312678537031
Submitter: Hugh Davenport (<email address hidden>)
Branch: 1.6_STABLE

commit 3e5f6b64271d8866266a3a764fd6312678537031
Author: Hugh Davenport <email address hidden>
Date: Mon Sep 24 09:32:35 2012 +1200

    Fix width of responsive menu (Bug #1052071)

    The width was created as the combined width of all the
    submenu's, which have different widths dependant on size
    of screen.

    In CSS, there is a cutover at 600px (a media query), so
    this JS code to take elements off etc, should have the
    same cutover width.

    Change-Id: Ibe71db1bee73e70960740ebcb7a1bb1a3179e436
    Signed-off-by: Hugh Davenport <email address hidden>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 status fixreleased
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iJwEAQECAAYFAlCbHO8ACgkQuMoJ2LQ3zxH8TAP/YN4BiCJZsn5a899/0UzV31Qg
lM8LXAwZWa6zFv6t0BQUHCqe6eFK9wPp51qgCWWXjUZ3vvvVcsyeWp6626aBFKSU
pCQXI9E7huPw802nJQ9WcZXRBUmgw87ww72Tx4mybnu7SPSrkZgXdnPGSMwDs89N
oWvTpl7Xuac48e6p0lU=
=ouU+
-----END PGP SIGNATURE-----