glance-scrubber crashes and doesn't scrub when not in daemon mode

Bug #1052537 reported by Paul Bourke
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Medium
Paul Bourke

Bug Description

The scrubber seems to be crashing when run via the cli/cron .

There also seems to be a problem with pool.starmap not getting scheduled when run via the same scenario, resulting in images that are pending_delete not getting scrubbed.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/13200

Changed in glance:
assignee: nobody → Paul Bourke (pauldbourke)
status: New → In Progress
Brian Waldon (bcwaldon)
Changed in glance:
milestone: none → grizzly-1
Brian Waldon (bcwaldon)
Changed in glance:
importance: Undecided → Medium
Thierry Carrez (ttx)
no longer affects: glance/folsom
Changed in glance:
milestone: grizzly-1 → folsom-rc2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/13200
Committed: http://github.com/openstack/glance/commit/1182871ddde43ff8721599d7cb22b211e09e0108
Submitter: Jenkins
Branch: master

commit 1182871ddde43ff8721599d7cb22b211e09e0108
Author: Paul Bourke <email address hidden>
Date: Tue Sep 18 12:40:40 2012 +0100

    Fix scrubber start & not scrubbing when not daemon

    1) Scrubber not starting
    When the scrubber is run from the command line or via cron, it would try
    to call it's app object which resulted in a TypeError.

    2) Scrubber not scrubbing
    In the same usage scenario as above, the delete jobs added to the
    starmap are never started. A slight delay is enough to start these.

    Also add a functional test designed to excercise the scrubber when run
    in "regular mode", which covers both these cases. I've run the test
    successfully with 1000 images, which should be enough to prove the
    sleep(0.1) does the trick.

    Fixes bug 1052537.

    Change-Id: If29704d8a425194085b59b7dfd265ffaef16302c

Changed in glance:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/13349

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (milestone-proposed)

Reviewed: https://review.openstack.org/13349
Committed: http://github.com/openstack/glance/commit/c4173820b0e5836e1af99a428b140647c1db70af
Submitter: Jenkins
Branch: milestone-proposed

commit c4173820b0e5836e1af99a428b140647c1db70af
Author: Paul Bourke <email address hidden>
Date: Tue Sep 18 12:40:40 2012 +0100

    Fix scrubber start & not scrubbing when not daemon

    1) Scrubber not starting
    When the scrubber is run from the command line or via cron, it would try
    to call it's app object which resulted in a TypeError.

    2) Scrubber not scrubbing
    In the same usage scenario as above, the delete jobs added to the
    starmap are never started. A slight delay is enough to start these.

    Also add a functional test designed to excercise the scrubber when run
    in "regular mode", which covers both these cases. I've run the test
    successfully with 1000 images, which should be enough to prove the
    sleep(0.1) does the trick.

    Fixes bug 1052537.

    Change-Id: If29704d8a425194085b59b7dfd265ffaef16302c

Changed in glance:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/13627

Changed in glance:
status: Fix Released → In Progress
Brian Waldon (bcwaldon)
Changed in glance:
status: In Progress → Fix Released
Changed in glance:
status: Fix Released → In Progress
Thierry Carrez (ttx)
Changed in glance:
milestone: folsom-rc2 → 2012.2
status: In Progress → Fix Released
Changed in glance:
status: Fix Released → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/13627
Committed: http://github.com/openstack/glance/commit/d032ad5d412d4bb77f9bfb7c7fca424399f80c42
Submitter: Jenkins
Branch: master

commit d032ad5d412d4bb77f9bfb7c7fca424399f80c42
Author: Paul Bourke <email address hidden>
Date: Tue Sep 25 12:43:35 2012 +0100

    Fix scrubber not scrubbing with swift backend

    It seems the fix for bug #1052537 was incomplete, as I have found
    glance-scrubber is still not completing it's work when run against a
    swift backend.

    With more investigation it seems the proper way to execute a
    starmap/imap is to consume it within a loop. This can be replicated by
    taking the simple web crawler example from http://eventlet.net/doc/ and
    removing the for loop from around the imap call.

    Also:
    * Add new test to check this failure against Swift (respects the
      GLANCE_TEST_SWIFT_CONF environment variable).

    Fixes bug 1056127

    Change-Id: I2d289666b99f3216a6d424dbbacbd2d10899263d

Changed in glance:
status: In Progress → Fix Committed
Changed in glance:
milestone: 2012.2 → none
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.