WebApps: Applications Data

Amazon userscript isCorrectPage() method is too selective

Bug #1058241 reported by Robert Carr on 2012-09-28

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	WebApps: Applications Data	Fix Released	Undecided	Robert Carr

Bug Description

Amazon userscript isCorrectPage() method is too selective.

In particular it will sometimes return false on international Amazon domains (Though I have also been served versions of Amazon.co.uk that worked! ><).

Related branches

lp:~robertcarr/webapps-applications/fix-amazoncouk

Merged into lp:webapps-applications at revision 367

Alexandre Abreu (community): Approve on 2012-10-01

jenkins (community): Needs Fixing (continuous-integration) on 2012-09-28

Revision history for this message

Robert Carr (robertcarr) wrote on 2012-09-28:

It's safe to remove isCorrectPage()

The userscript glob (http://amazon.*/*) may load on unwanted sites (i.e. http://amazon.hacker.it/adobe-acrobat). However the list of domain parameters to Unity.init + cross domain check in unity-firefox-extension will prevent Unity.init method from succeeding.

Robert Carr (robertcarr) on 2012-10-01

Changed in webapps-applications:
status:	In Progress → Fix Committed

Maxim Ermilov (zaspire) on 2012-10-05

Changed in webapps-applications:
status:	Fix Committed → Fix Released

Adolfo Jayme Barrientos (fitojb) on 2014-02-24

no longer affects:

webapps-applications (Ubuntu Raring)

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.