OpenStack Compute (nova)

Add version to network rpc api

Bug #1060197 reported by Russell Bryant on 2012-10-02

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Compute (nova)	Fix Released	High	Russell Bryant	OpenStack Compute (nova) 2013.1 "grizzly"

Bug Description

In Folsom, versioning was added for rpc APIs. The network and volume APIs were not converted (pending whether or not they would be removed or not). The network rpc API should be versioned since it's not getting removed in the immediate future.

Russell Bryant (russellb) on 2012-10-02

Changed in nova:
assignee:	nobody → Russell Bryant (russellb)
importance:	Undecided → High
status:	New → Incomplete
status:	Incomplete → Confirmed

Guangyu Suo (yugsuo) on 2012-10-04

Changed in nova:
status:	Confirmed → In Progress
status:	In Progress → Confirmed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2012-10-09: Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/14259

Changed in nova:
status:	Confirmed → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2012-10-18: Fix merged to nova (master)

Reviewed: https://review.openstack.org/14259
Committed: http://github.com/openstack/nova/commit/e8560a76cbaaebd25f60886f5966297a94597993
Submitter: Jenkins
Branch: master

commit e8560a76cbaaebd25f60886f5966297a94597993
Author: Russell Bryant <email address hidden>
Date: Mon Oct 1 01:21:07 2012 +0100

Add version to network rpc API.

    This patch adds versioning support for the nova-network rpc API. During
    Folsom development I added versioning to all rpc APIs with the exception
    of network and volume. I was holding off on those to see what the fate
    of that code in nova was going to be for sure. Adding it to the volume
    API in nova doesn't make much sense at this point (but doing it in
    Cinder does). Since nova-network is sticking around for a while, it
    seems worthwhile to add a version number to the API for any future
    changes while the code is still in the tree.

    There are plenty of things in this rpc API that could be cleaned up or
    improved, but I held off on doing any of those things. I would
    recommend the same for anyone else (unless it's a bug that needs to be
    fixed). I think any further improvements should be focused on Quantum
    integration with Nova or Quantum itself.

Fixes bug 1060197.

Change-Id: I63ce57657388166544202af9c44c2298ae551aea