OpenStack Compute (nova)

Instance reboot not working.

Bug #1071017 reported by Kravchenko Pavel
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Dan Smith
OpenStack Compute (nova) 2013.1 "grizzly"

Bug Description

After Change: https://review.openstack.org/13921 network_info attribute that passed to the compute.manager.reboot_instance dispatched as 'list' instead of NetworkInfo. As a result it fails in the self._legacy_nw_info call for conversion because list doesn't have NetworkInfo method 'legacy()'.

See original description
Kravchenko Pavel (kravchenko-pavel)
description: updated
description: updated
Vish Ishaya (vishvananda)
Changed in nova:
status: New → Triaged
importance: Undecided → High
Dan Smith (danms)
Changed in nova:
assignee: nobody → Dan Smith (danms)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/14854

Changed in nova:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/14854
Committed: http://github.com/openstack/nova/commit/03105bf245860dd67735c072eb7c2ec85dd3c14a
Submitter: Jenkins
Branch: master

commit 03105bf245860dd67735c072eb7c2ec85dd3c14a
Author: Dan Smith <email address hidden>
Date: Thu Oct 25 14:02:55 2012 -0700

    Rehydrate NetworkInfo in reboot_instance()

    In the process of implementing no-db-compute, the compute manager's
    reboot_instance() was stripped of its database accesses for getting
    an instance's block and network device info. That information is
    now passed in from the API layer over RPC.

    In the offending changeset (), the network_info was getting coerced
    to a list and thus calls to NetworkInfo.legacy() were failing in the
    manager's _legacy_nw_info() method. This patch rehydrates the
    NetworkInfo using the existing method for doing so, which fixes
    bug 1071017. A test is also added to prevent future regressions.

    Change-Id: I8fd1c2dde573bb7da3bfe1ee3193f9ba1167aaa7

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → grizzly-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-1 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.