OpenStack Identity (keystone)

I18N issue: some log/messages are not wrapped with _()

Bug #1075090 reported by Ying Chun Guo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Wishlist
Nachiappan
OpenStack Identity (keystone) 2013.1 "grizzly"

Bug Description

Hi, all

In keystone source code, some LOG messages or printing messages are wrapped with _(), some are not. I used a program to scan all the source code, and saved all the LOG messages and printing messages without _() into a file.

We need to fix this small but important issue, to make our codes look better.

Daisy

Revision history for this message
Ying Chun Guo (daisy-ycguo) wrote :
Joseph Heck (heckj)
Changed in keystone:
status: New → Triaged
importance: Undecided → Wishlist
Revision history for this message
Ying Chun Guo (daisy-ycguo) wrote :

Hi,

I'm going to work on it, because it is required by my customers. Thanks

Daisy

Changed in keystone:
assignee: nobody → Ying Chun Guo (daisy-ycguo)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/16114

Changed in keystone:
assignee: Ying Chun Guo (daisy-ycguo) → Nachiappan (nachiappan-veerappan-nachiappan)
status: Triaged → In Progress
Revision history for this message
Ying Chun Guo (daisy-ycguo) wrote :

Hi,

I'm not able to open that review page. Are you still working on this bug?

Daisy

Revision history for this message
Nachiappan (nachiappan) wrote :

Hi,

I submitted the draft changes for review by guang. I have added you as a reviewer.

Nachi

Revision history for this message
Ying Chun Guo (daisy-ycguo) wrote :

Thank you, Nachi.

I added some comments.

Please take a look.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/16114
Committed: http://github.com/openstack/keystone/commit/84a0b2df5932fabb0cdaaaddeb86d1f55a7ac06e
Submitter: Jenkins
Branch: master

commit 84a0b2df5932fabb0cdaaaddeb86d1f55a7ac06e
Author: Nachiappan VR N <email address hidden>
Date: Wed Nov 14 10:01:59 2012 -0800

    Bug 1075090 -- Fixing log messages in python source code to support internationalization.

    Change-Id: I6b50abaa82effad8feaaac8d85086ca8b5d42590

Changed in keystone:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in keystone:
milestone: none → grizzly-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in keystone:
milestone: grizzly-2 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.