upstream should handle cc_ renames

Bug #1075980 reported by Scott Moser
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
cloud-init
Fix Released
Medium
Joshua Harlow

Bug Description

Previously, I have handled renames of config modules in the Ubuntu packaging.
However, that means that really just throws that maintenance onto the packager. It'd be much nicer if cloud-init handled it somehow. The specific motivation for this is [1]. If the packaging doesn't change to address it, the new "package-update-upgrade-install" would be run again as it has never been run before.

The things I'd like to have:
 * ability to specify that
    * apt-update-upgrade was split into 2 pieces: apt-configure, package-update-upgrade-install
    * foo changed in name to bar

 * it looks like semaphores can contain '-' in them, based on their name in the config. Also, the config is inconsistent even in itself with respect to usage of '_' or '-'. I'd like to be consistent in the config (config/cloud.cfg) and enforce that 'set_hostname' is the same as 'set-hostname'.

--
[1] https://code.launchpad.net/~harlowja/cloud-init/pkg-up-install-goodies/+merge/130019

Related branches

Scott Moser (smoser)
summary: - upstream package should handle cc_ renames
+ upstream should handle cc_ renames
Scott Moser (smoser)
Changed in cloud-init:
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Scott Moser (smoser) wrote :

I talked with harlowja about this and we agreed that it makes sense to at least look at a 'cc_fixup' module that would run first, and it would go through and apply updates. psuedocode:
 if module_ran("apt-update-upgrade"):
    mark_ran("apt-configure", "package-update-upgrade-install")
if module_ran("foo-was-renamed-to-bar"):
   mark_ran("bar")

Where 'mark_ran' might even put the cloud-init version that applied the change.

Revision history for this message
Scott Moser (smoser) wrote :

it could also go through any semaphores with '-' in their name and canonicalize them.

Revision history for this message
Joshua Harlow (harlowja) wrote :
Revision history for this message
Scott Moser (smoser) wrote :

this was fix-committed in revno 710.

Changed in cloud-init:
assignee: nobody → Joshua Harlow (harlowja)
status: Triaged → Fix Committed
Scott Moser (smoser)
Changed in cloud-init:
status: Fix Committed → Fix Released
Revision history for this message
James Falcon (falcojr) wrote :
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.