neutron

Unitest test_l3_plugin.L3NatExtensionTestCase.test_router_list's mocked value need be verified

Bug #1078150 reported by Alex Xu
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Kyle Mestery
neutron 2013.1 "grizzly"

Bug Description

In unitest test_l3_plugin.L3NatExtensionTestCase.test_router_list
Only verified the status code, as below:
self.assertEqual(res.status_int, exc.HTTPOk.code)

As Mark suggestion, It need verifiy mock return value too.

dan wendlandt (danwent)
Changed in quantum:
status: New → Confirmed
importance: Undecided → Low
Kyle Mestery (mestery)
Changed in quantum:
assignee: nobody → Kyle Mestery (mestery)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/18151

Changed in quantum:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (master)

Reviewed: https://review.openstack.org/18151
Committed: http://github.com/openstack/quantum/commit/9a442afbfa409a67b619d0f5d59036143407ab4a
Submitter: Jenkins
Branch: master

commit 9a442afbfa409a67b619d0f5d59036143407ab4a
Author: Kyle Mestery <email address hidden>
Date: Fri Dec 14 15:00:08 2012 +0000

    Update test_router_list to validate the router returned.

    For unit test test_l3_plugin.L3NatExtensionTestCase.test_router_list,
    correctly validate the value returned from listing the routers.

    Fixes bug 1078150

    Change-Id: I5ae559c37f43c1b977065a3508b6efb4375a2c1a

Changed in quantum:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in quantum:
milestone: none → grizzly-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in quantum:
milestone: grizzly-2 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.