migrations unit test should opportunistically test postgres

Bug #1084567 reported by Sean Dague
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Kurt Taylor

Bug Description

nova/tests/test_migrations.py has opportunitic testing for mysql that makes it test mysql migrations if a special database is in place with the right username and password. The lets it test in the automated CI system.

We should also do this for postgresql as part of our postgresql as a first class citizen effort.

Sean Dague (sdague)
Changed in nova:
importance: Undecided → Medium
status: New → Triaged
Sean Dague (sdague)
Changed in nova:
assignee: nobody → Kurt Taylor (krtaylor)
Kurt Taylor (krtaylor)
Changed in nova:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/19951

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/19977

Revision history for this message
Kurt Taylor (krtaylor) wrote :

Active patch set at:
Review: https://review.openstack.org/19951

The other set is abandoned.

Changed in nova:
assignee: Kurt Taylor (krtaylor) → Sean Dague (sdague-b)
Kurt Taylor (krtaylor)
Changed in nova:
assignee: Sean Dague (sdague-b) → Kurt Taylor (krtaylor)
Changed in nova:
assignee: Kurt Taylor (krtaylor) → Sean Dague (sdague-b)
Changed in nova:
assignee: Sean Dague (sdague-b) → Kurt Taylor (krtaylor)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/19951
Committed: http://github.com/openstack/nova/commit/5dcf4dd9b2e996913c8fe4bfa20a6186e9a066ab
Submitter: Jenkins
Branch: master

commit 5dcf4dd9b2e996913c8fe4bfa20a6186e9a066ab
Author: Kurt Taylor <email address hidden>
Date: Thu Jan 17 15:15:59 2013 -0500

    Added Postgres CI opportunistic test case

    Added test case and support functions for CI opportunistic testing
    using a PostgreSQL database, as part of our postgresql as a first
    class citizen effort.

    rebased again on top of test migration with data framework

    clean up debug, and ensure pg will fail to connect gracefully

    fix previous migration test which was inserting a key by id, which
    postgresql doesn't like, as it doesn't adjust the autoincrement
    counter.

    added driver to connection string for mysql

    Updated comment to expose how to do this on pg easily

    Fixes:
    bug 1084567

    Change-Id: If0bfe5cf748f6d5724d17082be6d18b6f96f6ee4

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → grizzly-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-3 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.