Behavior of deleting non-existent keypairs changed

Bug #1086980 reported by David Kranz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Mauro S M Rodrigues

Bug Description

This change was caused by https://review.openstack.org/#/c/17285/ and caused these errors in tempest from
http://logs.openstack.org/17351/1/gate/gate-tempest-devstack-vm/21154/console.html.gz

17:39:13 ======================================================================
17:39:13 FAIL: Non-existant key deletion should throw a proper error
17:39:13 ----------------------------------------------------------------------
17:39:13 Traceback (most recent call last):
17:39:13 File "/opt/stack/tempest/tempest/tests/compute/keypairs/test_keypairs.py", line 148, in test_keypair_delete_nonexistant_key
17:39:13 self.fail('nonexistent key')
17:39:13 AssertionError: nonexistent key
17:39:13 """Fail immediately, with the given message."""
17:39:13 >> raise self.failureException('nonexistent key')
17:39:13
17:39:13
17:39:13 ======================================================================
17:39:13 FAIL: Non-existant key deletion should throw a proper error
17:39:13 ----------------------------------------------------------------------
17:39:13 Traceback (most recent call last):
17:39:13 File "/opt/stack/tempest/tempest/tests/compute/keypairs/test_keypairs.py", line 148, in test_keypair_delete_nonexistant_key
17:39:13 self.fail('nonexistent key')
17:39:13 AssertionError: nonexistent key
17:39:13 """Fail immediately, with the given message."""
17:39:13 >> raise self.failureException('nonexistent key')
17:39:13
17:39:13
17:39:13 ======================================================================
17:39:13 FAIL: A DELETE request for another user's keypair should fail
17:39:13 ----------------------------------------------------------------------
17:39:13 Traceback (most recent call last):
17:39:13 File "/usr/lib/python2.7/dist-packages/nose/tools.py", line 87, in newfunc
17:39:13 raise AssertionError(message)
17:39:13 AssertionError: test_delete_keypair_of_alt_account_fails() did not raise NotFound
17:39:13 'test_delete_keypair_of_alt_account_fails() did not raise NotFound' = "%s() did not raise %s" % ('test_delete_keypair_of_alt_account_fails', 'NotFound')
17:39:13 >> raise AssertionError('test_delete_keypair_of_alt_account_fails() did not raise NotFound')
17:39:13
17:39:13
17:

Tags: tempest
Michael Still (mikal)
Changed in nova:
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
David Kranz (david-kranz) wrote :

I'm not sure what Medium means for the nova team, but this really needs to be fixed before releasing Grizzly.

tags: added: tempest
Changed in nova:
assignee: nobody → Mauro Sergio Martins Rodrigues (maurosr)
status: Triaged → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/24179

Changed in nova:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/24179
Committed: http://github.com/openstack/nova/commit/b883b259fc4c2b651fd27ac0a392f8918b77489a
Submitter: Jenkins
Branch: master

commit b883b259fc4c2b651fd27ac0a392f8918b77489a
Author: Mauro S. M. Rodrigues <email address hidden>
Date: Tue Mar 12 10:09:00 2013 -0400

    Check keypair destroy result operation

    This checks the result of delete operation over keypairs to see if it
    affected any row (this is what delete returns), if not raises
    KeyPairNotFoundException.

    Also adds tests for keypair db api.

    Fix bug 1086980

    Change-Id: I7e822c0661c563db01040ae2d57aacfe677d72b0

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → grizzly-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-rc1 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.