juju-gui

makefile and tests are not run automatically before landing

Bug #1087110 reported by Gary Poster
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
juju-gui
Fix Released
High
Unassigned

Bug Description

Our automated tests are not run automatically. Our makefiles are not run from a pristine state automatically. This is error-prone and has, unsurprisingly, bitten us more than once.

We should make our tests run automatically. lbox has a test hook which is not perfect for this purpose but would be an improvement, if it ran make clean (or at least some version of "make clean" that removed everything except for the downloaded bits like the node_modules), make, and then a test that actually verified the results before submitting the branch.

Revision history for this message
Madison Scott-Clary (makyo) wrote :

I believe this is no longer the case after the recent PhantomJS branch, at least the tests portion. Anyone able to confirm?

Revision history for this message
Gary Poster (gary) wrote :

It's true that the tests are done. I think we should discuss whether we want what I describe, in which case we can do it very quickly now; or if we want something else, in which case we can document it and close this bug.

Revision history for this message
Madison Scott-Clary (makyo) wrote :

Sorry for the status change; wrong tab.

Is this valid anymore?

Changed in juju-gui:
status: Triaged → Fix Released
status: Fix Released → Triaged
Revision history for this message
Gary Poster (gary) wrote :

We don't test the Makefile per se, and I want better tests, but I'm willing to say this one is addressed. Thank you.

Revision history for this message
Gary Poster (gary) wrote :

Better test automation, I should say.

Changed in juju-gui:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.